Skip to content

Fixed OnlineOption crashing when none is selected #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pariterre merged 2 commits into from
Apr 9, 2026
Merged

Fixed OnlineOption crashing when none is selected #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b5a807
Added a todo for pariterre
pariterre Apr 9, 2026
93e4886
Fixed online_option crashing on macosx instead of ignoring
pariterre Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bioptim/interfaces/interface_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ def generic_online_optim(interface: SolverInterface, ocp, show_options: AnyDictO
show_options = {}

online_optim = interface.opts.online_optim.get_default()
if online_optim == OnlineOptim.MULTIPROCESS:
if online_optim is None:
return
elif online_optim == OnlineOptim.MULTIPROCESS:
to_call = OnlineCallbackMultiprocess
elif online_optim == OnlineOptim.SERVER:
to_call = OnlineCallbackServer
Expand Down
1 change: 1 addition & 0 deletions bioptim/models/biorbd/biorbd_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ def __init__(
if parameters is not None:
for param_key in parameters:
parameters[param_key].apply_parameter(self)
# TODO: if friction_coefficients is a parameter it creates free variables
self._friction_coefficients = friction_coefficients

self.external_force_set = self._set_external_force_set(external_force_set)
Expand Down
Loading