Fix compiler and ubsan warnings#359
Merged
Merged
Conversation
pariterre
approved these changes
Apr 24, 2025
Member
pariterre
left a comment
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @smnnlt)
Member
|
Sweet again :) Thank for you help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the R implementation of ezc3d I found some compiler and ubsan warnings generated by the C++ source code. I tried to remove them by making the following modification:
hex2uintandhex2intby disregarding extra bytes. Also using bit shifting which should be faster and safer (0f99702)ezc3d::DataNS::AnalogsNS::Info::Info(61945bb)ezc3d::c3d::frames(86f2bf6)I have yet to get used to the test suite, so I have not tested the modifications so far (apart from the R implementation, where I could remove the warnings and the code still works as intended).
This change is