Show an error message when pip install fails with network issues#13971
Open
sepehr-rs wants to merge 11 commits into
Open
Show an error message when pip install fails with network issues#13971sepehr-rs wants to merge 11 commits into
sepehr-rs wants to merge 11 commits into
Conversation
sepehr-rs
changed the title
Member
Author
|
All tests are passing on my machine, but I’ll take a closer look to see what might be causing the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4271, #3642, #11463, #13406, #12384 by showing an error message when pip encounters network errors during
pip install. I’ll be adding tests for this soon, and would really appreciate any feedback or suggestions on the implementation.