Modernize project build script#13997
Open
sbidoul wants to merge 1 commit into
Open
Conversation
sbidoul
changed the title
sbidoul
added
the
skip news
sbidoul
force-pushed
the
build-project-pylock
branch
from
aee7ba2 to
9d64f51
Compare
1 task
Member
|
Here's the depandabot issue: dependabot/dependabot-core#12094 |
|
|
||
| Running `python build-project.py` will produce pip build artifacts in `../dist`. | ||
|
|
||
| Update `pylock.toml` with `pip lock --group build`. |
Member
There was a problem hiding this comment.
We should create a CI job that does this, in the current state of supply chain attacks I do not want it to be a requirement that the reviewer should hand verify to protect against name or hash confusion attacks on submitted PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylock.tomlinstead ofrequirements.txtpylock.tomlfrom a dependency group withpip lockThe drawback, maybe, is that dependabot does not support this.