Skip to content

docs: upgrade HTTP links to HTTPS#14017

Open
sridhar-3009 wants to merge 4 commits into
pypa:mainfrom
sridhar-3009:docs/fix-http-links
Open

docs: upgrade HTTP links to HTTPS#14017
sridhar-3009 wants to merge 4 commits into
pypa:mainfrom
sridhar-3009:docs/fix-http-links

Conversation

@sridhar-3009
Copy link
Copy Markdown

Summary

Part of #13664 — auditing HTTP links in the docs.

Two links upgraded from http:// to https://:

  1. docs/html/user_guide.rst — PSF blog announcement
  2. docs/html/ux-research-design/guidance.md — Simply Secure Knowledge Base

Both destinations support HTTPS and redirect correctly from HTTP.

- user_guide.rst: PSF blog announcement link http→https
- ux-research-design/guidance.md: Simply Secure Knowledge Base link http→https

Part of pypa#13664
@sepehr-rs
Copy link
Copy Markdown
Member

Hi @sridhar-3009, thanks for your contribution!
Since this is a trivial change, could you please add a .trivial.rst news entry as well? You can find more details in the contributing guide here.

@sridhar-3009
Copy link
Copy Markdown
Author

Added news/14017.trivial.rst — pushed now.

Comment thread news/14017.trivial.rst Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the contributing guidelines, please leave the trivial news file empty.

@sridhar-3009
Copy link
Copy Markdown
Author

@sepehr-rs Fixed — the file is now empty.

Copy link
Copy Markdown
Member

@sepehr-rs sepehr-rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sepehr-rs
Copy link
Copy Markdown
Member

Wait. I just noticed something. The news file number should match the issue being fixed, not the PR number. Please review the contributing guidelines more carefully. I suspect this may be an automated account, but since the changes are trivial, I chose not to close the PR.

@sridhar-3009
Copy link
Copy Markdown
Author

@sepehr-rs Apologies for the wrong file number — renamed to news/13664.trivial.rst and pushed.

I'm fairly new to contributing to open source and still getting familiar with project-specific conventions — that's why I used the PR number instead of the issue number for the news file. I've corrected it now. I do understand the change I submitted: it upgrades two http:// links to https:// in the docs. Thanks for the feedback and for taking the time to review it.

Copy link
Copy Markdown
Member

@sepehr-rs sepehr-rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and for fixing the news entry naming. The latest revision looks correct to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants