minor fixes to get central path for cloud models#3486
Merged
Conversation
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary:
- Fixes cloud model handling in the "Get Central Path" tool by deriving the ACC/BIM360 project id from
revit.doc.GetProjectId()instead ofmodel_path.GetProjectGUID(), stripping theb.Forge DM prefix. - Updates docstring wording to mention BIM360/ACC/Forma instead of just ACC.
- Appends a "●" indicator to the button title (all locales) to signal the Shift+Click alternate behavior.
Review Summary:
Overall a small, well-scoped fix. Two issues were found:
Document.GetProjectId()is a Revit 2022+ API; since this bundle has nomin_revit_versiongate and pyRevit still supports Revit 2019-2021, Shift+Clicking on a cloud model in those versions will now throw instead of opening the docs URL - the existingHOST_APP.is_newer_than(2026)pattern a few lines above should be extended to guard this new call too.- The
bundle.yamltooltip text (shown in the Revit ribbon, across all 8 languages) wasn't updated to match the new "BIM360/ACC/Forma" wording added to the script docstring, leaving the two descriptions out of sync.
The "●" bullet addition is consistent with pyRevit's convention for indicating Shift+Click alternate behavior, and the Forge DM b. prefix stripping logic is correct per Autodesk's APS documentation.
Suggestions
jmcouffin
approved these changes
Jul 13, 2026
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.5.4 |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.5.4 |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.5.4 |
Contributor
|
📦 New work-in-progress (wip) builds are available for 6.5.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix cloud models, add indicator, update name to forma
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}