Skip to content

Fix icon theme not updating on reload after Dark/Light mode switch #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −0
Open

Fix icon theme not updating on reload after Dark/Light mode switch #3493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dev/pyRevitLoader/pyRevitAssemblyBuilder/UIManager/SessionManagerService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ public void LoadSession()
stepStopwatch.Restart();
_extensionManager?.ClearParserCaches();
_logger.Debug($"[PERF] ClearParserCaches: {stepStopwatch.ElapsedMilliseconds}ms");

// Clear the cached theme so icon selection reflects the active theme at reload time.
// Without this, switching between Dark and Light mode requires a full Revit restart
// because the first-load theme detection result is retained for the process lifetime.
RevitThemeDetector.ClearCache();

// Initialize the ScriptExecutor before executing any scripts
stepStopwatch.Restart();
Expand Down