updating svi tutorial 1 with cells instead of inline#2723
Open
Padarn wants to merge 3 commits into
Open
Conversation
Member
|
@Padarn I'm undecided whether this improves readability. On the one hand users can now execute code cells everywhere in the notebook, not just at the end. On the other hand that executability requires extra machinery , and that extra machinery slightly steals attention from the salient parts of pyro being explained. @ab-10 can you explain a bit more about how you'd like to execute the code in the tutorial, and how the final executable code block isn't accomplishing that? @eb8680 do you have any opinion? |
Author
|
Hi, @fritzo thanks for taking a look. I'm actually in agreement with you that this doesn't really improve readability. Possibly it would make sense to remove the final 'all in one' block', if the cells are executable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2714
See new version versus old version.