Implementation of quantiles for messenger guides [WIP]#2988
Open
vitkl wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Is it possible to restart the checks? Maybe the issue resolved itself with new changes to pyro/pytorch? |
vitkl
added a commit
to BayraktarLab/cell2location
that referenced
this pull request
Jan 25, 2022
Member
|
not sure how to restart in github actions, but you could merge Pyro dev branch and push, that should rerun ci |
Merging dev branch
Accidentally committed raise error used for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contributes the implementation of quantiles for messenger guides - which resembles how this is done in AutoNormal. I see certain errors that I don't know how to address (https://github.com/pyro-ppl/pyro/runs/4490764371?check_suite_focus=true#step:5:22410) - namely, the messenger guide tries to expand returned quantiles
new.v = self.v.expand(batch_shape + self.event_shape). This can potentially be addressed by running a for loop over requested quantiles like this:Please let me know what you think @fritzo