Raise ValueError for negative plate sizes#3451
Open
kimjune01 wants to merge 1 commit into
Open
Conversation
Negative plate sizes silently produce incorrect log-likelihood scaling (size/batch_size becomes negative). Add an early validation check in SubsampleMessenger._subsample to raise a clear ValueError before any downstream computation occurs. Fixes pyro-ppl#3407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3407.
Negative
sizeinpyro.plate()silently produces incorrect log-likelihoodscaling —
size / batch_sizebecomes negative. The existing validationcatches
size == 0but not negative values.Add a
ValueErrorcheck before the_Subsampledistribution is created.