ENH: unzip support for download#209
Merged
Merged
Conversation
This was referenced Oct 5, 2023
Member
Author
|
Needs a test for the new bits of code. The only routine that uses this is in pysatModels. Potentially we can create a test object with a few zipped files hosted here. |
Member
Author
|
Removed the gz support for now since the TIMED datasets have other problems. Can be expanded in the future. Moving forward without tests for the time being to support pysatModels. |
Member
Author
|
Documented need for tests and possible solutions as #213. |
Member
Author
|
Coverage change consistent with new lines of code. |
aburrell
reviewed
Oct 31, 2023
aburrell
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #103
Adds support to unzip files after download for zip files. Users can now specify a 'zip_method' as part of the download tags, which will send the zipped file to a temporary directory and extract it to the archival location.
Current version supports 'zip' only, but could be expanded for other file types later.
Type of change
How Has This Been Tested?
Tested with pysatModels at pysat/pysatModels#132
Test Configuration:
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release