fix: iina next button hanging#1552
Conversation
Dhairya3391
requested review from
Derisis13 and
justchokingaround
as code owners
port19x
left a comment
port19x
left a comment
There was a problem hiding this comment.
Also bump the version.
Not sure why you're version bumping patch in the readme, but I'll allow it
|
Ah I see. You bumped the patch version in the readme in #1544 but continued along that branch without updating your fork first, thats why this PR would recommit that change |
|
why is this PR not getting merged? |
|
Good question. I vaguely recall having tested this and it doing something while not breaking anything |
port19x
left a comment
port19x
left a comment
There was a problem hiding this comment.
Sorry for all this delay.
I'm not gonna promise I'll react quickly to adapting the requested changes, but I do plan to get this merged this week.
Thank you for your contribution and patience
|
Did you read my prior review? You haven't implemented any of it yet |
- Check for existing IINA instance using pgrep before launching - Skip --keep-running flag when IINA instance already exists to prevent hanging - Remove wait command for IINA when using external menu to avoid deadlocks - This resolves the issue where clicking Next would hang after sed call when there's an existing IINA player instance running Fixes the bug where: - Version: 4.10.3, OS: MacOS, Shell: zsh, Player: IINA - Next button hangs when IINA instance already open - Works fine when no existing IINA instances The fix detects running IINA processes and adjusts the launch parameters accordingly to prevent process conflicts and hanging behavior.
Co-authored-by: port19 <port19@port19.xyz>
Dhairya3391
force-pushed
the
fix-iina-next-button-hanging
branch
from
a3234ee to
f22df4a
Compare
|
Sorry, I missed that earlier — now fixed: removed redundant pid handling, kept a single bare wait, and trimmed the IINA comment while keeping the --keep-running omission when an instance exists. |
3 participants
Pull Request Template
Type of change
Description
Fixes IINA hanging issue when using the Next button with existing instances.
Problem: When using the Next button in ani-cli with IINA player on macOS, the program hangs after the sed call if there's already an existing IINA instance running. This only occurs when IINA is already open.
Root Cause: The
--keep-runningflag conflicts with existing IINA instances, and thewaitcommand can cause deadlocks with IINA processes.Solution:
pgrep -f "IINA"--keep-runningflag when IINA instance already existswaitfor IINA when using external menu to prevent hangingEnvironment Tested:
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-e(select episode) aka-r(range selection) works-Sselect index works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--exit-after-playauto exit after playing works--nextep-countdowncountdown to next ep works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases