fix: use ani-skip's AllAnime source for skip time lookups#1645
Open
synacktraa wants to merge 3 commits intopystardust:masterfrom
Open
fix: use ani-skip's AllAnime source for skip time lookups#1645synacktraa wants to merge 3 commits intopystardust:masterfrom
synacktraa wants to merge 3 commits intopystardust:masterfrom
Conversation
Pass AllAnime _id directly to ani-skip instead of fuzzy-matching titles through MAL's prefix search, which fails on AllAnime-specific display names (e.g. "1P" for One Piece). Requires ani-skip >= v1.1.0
71zenith
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #1531
Problem
ani-skip's
--queryflag resolves anime titles through MAL's prefix search API, which frequently fails when given AllAnime display names. For example, ani-cli passes "1P" (AllAnime's name for One Piece) to ani-skip, but MAL has no idea what "1P" is. Same issue with season-specific titles that don't match MAL's naming.Fix
ani-skip v1.1.0 added AllAnime as a source (
-s allanime) and a direct ID flag (-i). Since ani-cli already has the AllAnime_idin$id, we can pass it directly instead of trying to fuzzy-match titles through MAL.Two lines changed:
MAL ID resolution (line 544):
Passes the AllAnime
_iddirectly to ani-skip, which resolves it to a MAL ID via AllAnime's API. No more title fuzzy-matching.Skip time fetch (line 310):
Uses
-iinstead of-qsince$mal_idis a numeric ID.-qstill works for this case but is being soft-deprecated for ID inputs in ani-skip.Note on
--skip-title--skip-title/ANI_CLI_SKIP_TITLEis now unused since we no longer pass titles to ani-skip. Left it in for now to avoid breaking anyone's configs — can be removed in a future cleanup if you prefer.Requires
ani-skip >= v1.1.0 (https://github.com/synacktraa/ani-skip/releases/tag/1.1.0)