Skip to content

feat: Add an method to check the version, and prompt user to update ani-cli.#1702

Closed
Jay-1409 wants to merge 3 commits into
pystardust:masterfrom
Jay-1409:master
Closed

feat: Add an method to check the version, and prompt user to update ani-cli.#1702
Jay-1409 wants to merge 3 commits into
pystardust:masterfrom
Jay-1409:master

Conversation

@Jay-1409
Copy link
Copy Markdown

@Jay-1409 Jay-1409 commented May 3, 2026

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

helps users against no ep released issues cased due to older version of ani-cli

Version 4.13.0
image

Version 4.14.0
image

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e (select episode) aka -r (range selection) works
  • -S select index works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works
  • --nextep-countdown countdown to next ep works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
  • All Providers: Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu e (TV) (3 m3u8, 3 mp4, 1 fast4speed, 1 sharepoint)
  • The examples of the help text

…, helps users against no ep released issues cased due to older version of ani-cli
@Jay-1409 Jay-1409 requested a review from Derisis13 as a code owner May 3, 2026 04:51
@Derisis13
Copy link
Copy Markdown
Collaborator

Even though lately it has been the case, we don't always release a new version due to breakage.
With that said, the request is async, so it doesn't slow the script down, and it's not blocking execution, only showing a warning. I like these.
What I don't like is awk (not cross compatible), and that it adds too many lines compared to the function it provides. Unless it can be done in a more conscise way, I can't fully support it.

@Jay-1409
Copy link
Copy Markdown
Author

Jay-1409 commented May 3, 2026

@Derisis13

Thanks for the feedback,
it really made me think a lot, and I implemented the recent commit.
Could you have a look at it and provide any feedback?

: )

@port19x
Copy link
Copy Markdown
Collaborator

port19x commented May 6, 2026

Idk, I don't like it

@port19x
Copy link
Copy Markdown
Collaborator

port19x commented May 6, 2026

The code is way too long and you're evidently still using awk.

But beyond the code, I find such warnings rude, especially considering we're in several package repositories where that should be the primary way to update.
-U is a fallback because ani-cli can experience real breakage and package maintainers tend to be on the slow side, plus for manual installs.

@port19x port19x closed this May 6, 2026
@Jay-1409
Copy link
Copy Markdown
Author

Jay-1409 commented May 6, 2026

Right,
Thanks for the feedback,

appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants