Skip to content

organise downloads into per-show folders in home#1709

Closed
ikanop wants to merge 1 commit into
pystardust:masterfrom
ikanop:organised-downloads
Closed

organise downloads into per-show folders in home#1709
ikanop wants to merge 1 commit into
pystardust:masterfrom
ikanop:organised-downloads

Conversation

@ikanop
Copy link
Copy Markdown

@ikanop ikanop commented May 6, 2026

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e (select episode) aka -r (range selection) works
  • -S select index works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --exit-after-play auto exit after playing works
  • --nextep-countdown countdown to next ep works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
  • All Providers: Youkoso Jitsuryoku Shijou Shugi no Kyoushitsu e (TV) (3 m3u8, 3 mp4, 1 fast4speed, 1 sharepoint)
  • The examples of the help text

@ikanop ikanop requested a review from Derisis13 as a code owner May 6, 2026 07:43
@port19x
Copy link
Copy Markdown
Collaborator

port19x commented May 6, 2026

No, this breaks current behavior and is not desirable

@port19x port19x closed this May 6, 2026
@ikanop
Copy link
Copy Markdown
Author

ikanop commented May 6, 2026

No, this breaks current behavior and is not desirable

Could you clarify what current behavior this breaks? My intention was only to create a subdirectory per title. If there’s a specific workflow or use case this affects, I’d like to understand so I can adjust the change.

@port19x
Copy link
Copy Markdown
Collaborator

port19x commented May 6, 2026

This breaks:

  • the environment variable ANI_CLI_DOWNLOAD_DIR, used by people to configure a dedicated download folter
  • the default of downloading in the current directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants