fix: pass MAL ID to ani-skip via -i instead of deprecated -q#1732
Closed
AmroAlJundi wants to merge 1 commit into
Closed
fix: pass MAL ID to ani-skip via -i instead of deprecated -q#1732AmroAlJundi wants to merge 1 commit into
AmroAlJundi wants to merge 1 commit into
Conversation
play_episode() called `ani-skip -q "$mal_id"`, passing the numeric MAL ID as a search query. Newer ani-skip treats -q as a title search, so the ID was searched literally, returned no match, printed "passing MAL ID via -q is deprecated, use -i instead", and intro skipping silently failed. Use -i for direct MAL ID lookup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With current
ani-skip, intro skipping (--skip) fails silently and prints:play_episode()callsani-skip -q "$mal_id" -e "$ep_no", passing the numeric MAL ID to-q, which newer ani-skip interprets as a title search query. The ID gets searched literally, no match is found, and no skip chapters are returned.Fix
Use
-i(direct MAL ID lookup) for$mal_id. The other call site (line 624,ani-skip -q "${skip_title:-${title}}") is a genuine title search and is left unchanged.Verification
Before fix:
ani-skip -q 1735searches MAL for the string "1735" -> no result, no skip.🤖 Generated with Claude Code