Fix logging handler option isolation

Author: tobiasraabe

src/_pytask/logging.py

@@ -437,10 +437,10 @@ def from_config(cls, config: dict[str, Any]) -> LoggingManager:
                 config["log_format"], datefmt=config["log_date_format"]
             ),
             live_log_handler=live_log_handler,
-            log_cli_level=log_cli_level,
+            log_cli_level=log_cli_level if live_log_handler is not None else None,
             log_level=config["log_level"],
             log_file_handler=log_file_handler,
-            log_file_level=log_file_level,
+            log_file_level=log_file_level if log_file_handler is not None else None,
         )
 
     @contextlib.contextmanager
@@ -453,11 +453,12 @@ def _catching_logs(self) -> Generator[None, None, None]:
             handlers.append(self.log_file_handler)
 
         original_level = root_logger.level
+        report_level = self.log_level if self.log_level is not None else original_level
         configured_levels = [
             level
             for level in (
+                report_level,
                 self.log_cli_level,
-                self.log_level,
                 self.log_file_level,
             )
             if level not in (None, logging.NOTSET)
@@ -469,9 +470,7 @@ def _catching_logs(self) -> Generator[None, None, None]:
             # reconfigures the root logger can affect pytask's own logging handlers.
             for handler in handlers:
                 handler.setLevel(
-                    self.log_level
-                    if handler is self.report_handler and self.log_level is not None
-                    else handler.level
+                    report_level if handler is self.report_handler else handler.level
                 )
                 root_logger.addHandler(handler)
 
@@ -562,7 +561,7 @@ def _create_log_file_handler(
 def _create_live_log_handler(
     *, config: dict[str, Any], log_cli_level: int | None
 ) -> logging.Handler | None:
-    if not (config["log_cli"] or config["log_cli_level"] is not None):
+    if not config["log_cli"]:
         return None
 
     live_log_handler = LiveLogHandler(plugin_manager=config["pm"])

tests/test_logging.py

@@ -211,6 +211,90 @@ def task_example(produces=Path("out.txt")):
     assert "INFO:hello from live log" in result.stdout
 
 
+def test_log_cli_level_from_config_does_not_enable_live_logging(tmp_path):
+    source = """
+    import logging
+
+    logger = logging.getLogger(__name__)
+
+    def task_example():
+        logger.info("hello from live log")
+    """
+    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
+    tmp_path.joinpath("pyproject.toml").write_text(
+        textwrap.dedent(
+            """
+            [tool.pytask.ini_options]
+            log_cli = false
+            log_cli_level = "INFO"
+            log_cli_format = "%(levelname)s:%(message)s"
+            """
+        )
+    )
+
+    result = run_in_subprocess(("pytask", tmp_path.as_posix()), cwd=tmp_path)
+
+    assert result.exit_code == ExitCode.OK
+    assert "INFO:hello from live log" not in result.stdout
+
+
+@pytest.mark.parametrize(
+    ("destination_args", "expected_destination_output"),
+    [
+        (
+            (
+                "--log-cli",
+                "--log-cli-level=INFO",
+                "--log-cli-format=%(levelname)s:%(message)s",
+            ),
+            "INFO:hello from destination-specific log",
+        ),
+        (
+            (
+                "--log-file=build.log",
+                "--log-file-level=INFO",
+                "--log-file-format=%(levelname)s:%(message)s",
+            ),
+            None,
+        ),
+    ],
+    ids=["live-log", "log-file"],
+)
+def test_destination_specific_levels_do_not_affect_failure_report(
+    tmp_path, destination_args, expected_destination_output
+):
+    source = """
+    import logging
+
+    logger = logging.getLogger(__name__)
+
+    def task_example():
+        logger.info("hello from destination-specific log")
+        raise Exception("boom")
+    """
+    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
+
+    result = run_in_subprocess(
+        (
+            "pytask",
+            tmp_path.as_posix(),
+            "--show-capture=log",
+            *destination_args,
+        ),
+        cwd=tmp_path,
+    )
+
+    assert result.exit_code == ExitCode.FAILED
+    assert "Captured log" not in result.stdout
+    if expected_destination_output is not None:
+        assert expected_destination_output in result.stdout
+    else:
+        assert (
+            tmp_path.joinpath("build.log").read_text()
+            == "INFO:hello from destination-specific log\n"
+        )
+
+
 @pytest.mark.parametrize(
     ("amount", "unit", "short_label", "expectation", "expected"),
     [