Fix when multiple product annotations are used. (#448)

Author: tobiasraabe

docs/source/changes.md

@@ -5,11 +5,12 @@ chronological order. Releases follow [semantic versioning](https://semver.org/)
 releases are available on [PyPI](https://pypi.org/project/pytask) and
 [Anaconda.org](https://anaconda.org/conda-forge/pytask).
 
-## 0.4.1 - 2023-10-08
+## 0.4.1 - 2023-10-xx
 
 - {pull}`443` ensures that `PythonNode.name` is always unique by only handling it
   internally.
 - {pull}`444` moves all content of `setup.cfg` to `pyproject.toml`.
+- {pull}`447` fixes handling multiple product annotations of a task.
 
 ## 0.4.0 - 2023-10-07
 

environment.yml

@@ -34,7 +34,7 @@ dependencies:
   - pytest-cov
   - pytest-xdist
   - tabulate
-  - tox-conda
+  - tox
 
   # Documentation
   - furo

src/_pytask/collect_utils.py

@@ -425,9 +425,9 @@ def parse_products_from_task_function(
         out = {"produces": collected_products}
 
     if parameters_with_product_annot:
-        has_annotation = True
-
+        out = {}
         for parameter_name in parameters_with_product_annot:
+            has_annotation = True
             if (
                 parameter_name not in kwargs
                 and parameter_name not in parameters_with_node_annot
@@ -465,7 +465,7 @@ def parse_products_from_task_function(
                 ),
                 value,
             )
-            out = {parameter_name: collected_products}
+            out[parameter_name] = collected_products
 
     if "return" in parameters_with_node_annot:
         has_return = True

tests/test_execute.py

@@ -771,3 +771,27 @@ def create_file(text: Annotated[int, node_text]) -> Annotated[str, node_file]:
 def test_pass_non_task_to_functional_api_that_are_ignored():
     session = pytask.build(tasks=None)
     assert len(session.tasks) == 0
+
+
+@pytest.mark.end_to_end()
+def test_multiple_product_annotations(runner, tmp_path):
+    source = """
+    from pytask import Product
+    from typing_extensions import Annotated
+    from pathlib import Path
+
+    def task_first(
+        first: Annotated[Path, Product] = Path("first.txt"),
+        second: Annotated[Path, Product] = Path("second.txt")
+    ):
+        first.write_text("first")
+        second.write_text("second")
+
+    def task_second(
+        first: Path = Path("first.txt"), second: Path = Path("second.txt")
+    ):
+        pass
+    """
+    tmp_path.joinpath("task_module.py").write_text(textwrap.dedent(source))
+    result = runner.invoke(cli, [tmp_path.as_posix()])
+    assert result.exit_code == ExitCode.OK