Skip to content

Expand conditions for recognizing main process #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DWesl wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Expand conditions for recognizing main process #252

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce3e539
Expand conditions for recognizing main process
DWesl Aug 23, 2020
3348f61
Change test to be more concise.
DWesl Aug 24, 2020
05343bf
Correct the sense of the test comparison.
DWesl Aug 24, 2020
9cebab1
Test ForkedFunc behavior on fork failure
DWesl Aug 24, 2020
e2dd0bb
Fix exceptions in new test
DWesl Aug 24, 2020
a318d82
Add gc.collect to ensure destructor triggered
DWesl Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions testing/process/test_forkedfunc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ def raise_oserror():
# BlockingIOError on py3k
raise OSError("Resource temporarily unavailable")
monkeypatch.setattr(os, "fork", raise_oserror)
with pytest.raises(OSError, "Resource temporarily unavailable"):
ff = py.process.ForkedFunc(boxf1)
ff.__del__()
assert not ff.tempdir.check()
with pytest.raises(OSError, match="Resource temporarily unavailable"):
py.process.ForkedFunc(boxf1)
# The second exception would be raised while leaving the with block
Comment thread
DWesl marked this conversation as resolved.
Outdated
# Not marking it should be equivalent to assert_does_not_raise

def test_basic_forkedfunc():
result = py.process.ForkedFunc(boxf1).waitfinish()
Expand Down