Skip to content

Commit 3955b18

Browse files
authored
Fix type hints of assert functions (#1271)
* Fix type hints of assert functions Updated type hints in assert functions to use Iterable instead of Collection. And have assertRaisesMessage return something to use as a context manager. * Remove unused 'Collection' import
1 parent a2a9495 commit 3955b18

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pytest_django/asserts.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class MessagesTestCase(MessagesTestMixin, TestCase):
2525
test_case = TestCase("run")
2626

2727
if TYPE_CHECKING:
28-
from collections.abc import Callable, Collection, Iterator, Sequence
28+
from collections.abc import Callable, Iterable, Iterator, Sequence
2929
from contextlib import AbstractContextManager
3030
from typing import Any, overload
3131

@@ -130,14 +130,14 @@ def assertRaisesMessage(
130130
expected_message: str,
131131
*args: Any,
132132
**kwargs: Any,
133-
) -> None: ...
133+
) -> Any: ...
134134

135135
def assertWarnsMessage(
136136
expected_warning: Warning,
137137
expected_message: str,
138138
*args: Any,
139139
**kwargs: Any,
140-
) -> None: ...
140+
) -> Any: ...
141141

142142
def assertFieldOutput(
143143
fieldclass: type[forms.Field],
@@ -146,7 +146,7 @@ def assertFieldOutput(
146146
field_args: Any = ...,
147147
field_kwargs: Any = ...,
148148
empty_value: str = ...,
149-
) -> None: ...
149+
) -> Any: ...
150150

151151
def assertHTMLEqual(
152152
html1: str,
@@ -201,15 +201,15 @@ def assertXMLNotEqual(
201201
# Removed in Django 5.1: use assertQuerySetEqual.
202202
def assertQuerysetEqual(
203203
qs: Iterator[Any] | list[Model] | QuerySet | RawQuerySet,
204-
values: Collection[Any],
204+
values: Iterable[Any],
205205
transform: Callable[[Model], Any] | type[str] | None = ...,
206206
ordered: bool = ...,
207207
msg: str | None = ...,
208208
) -> None: ...
209209

210210
def assertQuerySetEqual(
211211
qs: Iterator[Any] | list[Model] | QuerySet | RawQuerySet,
212-
values: Collection[Any],
212+
values: Iterable[Any],
213213
transform: Callable[[Model], Any] | type[str] | None = ...,
214214
ordered: bool = ...,
215215
msg: str | None = ...,

0 commit comments

Comments
 (0)