ruff: Removes all the ANN type ignores and fixes them#1237
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes all ANN (type annotation) type ignores from the Ruff configuration and adds proper type annotations throughout the codebase to fix the linting violations.
- Adds comprehensive type annotations to function parameters and return types
- Introduces new type aliases
_Userand_UserModelfor better type safety with Django user models - Updates imports to support proper type checking with TYPE_CHECKING blocks
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removes ANN-related ignore rules from Ruff configuration |
| pytest_django/django_compat.py | Adds type aliases for Django user models |
| pytest_django/fixtures.py | Adds type annotations to fixture functions and classes |
| pytest_django/plugin.py | Adds type annotations to internal functions |
| pytest_django/live_server_helper.py | Adds type annotation to __add__ method |
| pytest_django/asserts.py | Adds comprehensive type annotations to assertion functions |
| tests/test_fixtures.py | Adds type annotations and updates test function signatures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowest risk