ruff: Addresses issues with ARG#1239
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Ruff linting issues related to the ARG rule by adding # noqa: ARG001 and # noqa: ARG002 comments to suppress warnings about unused function and method arguments. The changes primarily affect test files and some core functionality where arguments are required by interfaces but not used in the implementation.
- Removes unused imports and function parameters in test files
- Adds type annotations for better code clarity
- Suppresses ARG warnings for legitimate unused arguments in fixtures and interface implementations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_initialization.py | Removes unused pytest import and monkeypatch parameter |
| tests/test_fixtures.py | Adds ARG suppression comments and type annotations for LiveServer |
| tests/test_database.py | Adds ARG suppression comments for unused fixture parameters |
| pytest_django_test/db_router.py | Adds ARG suppression for unused parameters in router methods |
| pytest_django_test/app/views.py | Adds ARG suppression for unused request parameter |
| pytest_django/runner.py | Adds ARG suppression for unused kwargs parameters |
| pytest_django/plugin.py | Adds ARG suppression for unused parameters |
| pytest_django/fixtures.py | Adds ARG suppression for unused fixture dependencies |
| pyproject.toml | Removes ARG001 and ARG002 from ignore list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.