Skip to content

fix: approx() tolerance not applied to sequences/mappings nested inside dicts #14498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ashutosh-177 wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −0
Open

fix: approx() tolerance not applied to sequences/mappings nested inside dicts #14498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b613c79
fix: approx() tolerance not applied to sequences/mappings inside dicts
Ashutosh-177 May 19, 2026
3ada952
Potential fix for pull request finding
Ashutosh-177 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/_pytest/python_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ def _approx_scalar(self, x) -> ApproxBase:
return ApproxDecimal(x, rel=self.rel, abs=self.abs, nan_ok=self.nan_ok)
if isinstance(x, (datetime, timedelta)):
return ApproxTimedelta(x, rel=self.rel, abs=self.abs, nan_ok=self.nan_ok)
if isinstance(x, Mapping):
return ApproxMapping(x, rel=self.rel, abs=self.abs, nan_ok=self.nan_ok)
if _is_sequence_like(x):
return ApproxSequenceLike(x, rel=self.rel, abs=self.abs, nan_ok=self.nan_ok)
Comment thread
Ashutosh-177 marked this conversation as resolved.
Outdated
return ApproxScalar(x, rel=self.rel, abs=self.abs, nan_ok=self.nan_ok)

def _yield_comparisons(self, actual):
Expand Down
Loading