Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
left a comment
tejasbadadare
left a comment
There was a problem hiding this comment.
Seems reasonable to me, left a couple comments. It would be great if you also run it by someone with better TS chops, maybe @cprussin ?
| chain.reveal_delay_blocks !== 1 ? "s" : "" | ||
| }`, | ||
| gasLimit: chain.gas_limit.toLocaleString(), | ||
| default_fee: chain.default_fee, |
There was a problem hiding this comment.
I don't think we should show this since it could confuse people or lead them to hardcode a value. Can we omit this or point them to the fee table with the correct dynamic values?
There was a problem hiding this comment.
We are not showing this at all. It's just there, not using this.
| explorer?: string; | ||
| } | ||
|
|
||
| export const EntropyDeploymentsConfig: Record<string, ChainOverride> = { |
There was a problem hiding this comment.
maybe rename this to EntropyDeploymentsOverride or add a comment to communicate that this overrides the data from fortuna's chains/configs/ API?
aditya520
force-pushed
the
chore(entropy)-dynamic-fee-table
branch
from
cc5b2ba to
1514a45
Compare
* Update solana_mainnet.json ADD JUPSOL TO DOCS * Update solana_mainnet.json --------- Co-authored-by: Ali Behjati <bahjatia@gmail.com>
* chore(entropy) What's new * update * requested changes
5 participants
Description
This PR take updated configs from fortuna
v1/chains/configsand updates contract address table. I use network-id/chain-id to map with viem to get up-to-date explorer and RPC, hence removes the need of updating docs for new chains.Moreover, we can manually edit/add link and rpcs as some chains are still not supported by viem.
Type of Change
Areas Affected
Checklist
pre-commit run --all-filesto check for linting errorsRelated Issues
Closes #
Additional Notes
Contributor Information
Screenshots