feat: Add ppm precision to swap v2 fees#472
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
guibescos
reviewed
Apr 4, 2025
Dewyer
force-pushed
the
feat/add-fee-precision
branch
from
3097111 to
237ad70
Compare
Dewyer
force-pushed
the
feat/add-fee-precision
branch
from
237ad70 to
8719866
Compare
guibescos
reviewed
Apr 4, 2025
guibescos
reviewed
Apr 4, 2025
guibescos
reviewed
Apr 7, 2025
guibescos
approved these changes
Apr 7, 2025
guibescos
reviewed
Apr 7, 2025
Dewyer
force-pushed
the
feat/add-fee-precision
branch
from
e94ceb1 to
4612bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
In this PR i increased the possible precision for the dynamic platform and referrer fees.
This required a bit of trickery hence the swap v2 account still used the swap v1 argument instruction data, so that the two implementations could share a context. Which has to broken here because the size of the referer fee ppm needs to be increased to u64 from u16 breaking wire compatibility. This introduces some duplication. The hack were the constraints are moved out of the account validator don't work because the instruction data still needs to deserialize properly even if we werent using fee token data.