Add referral fee ppm to auction server#527
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
anihamde
approved these changes
Apr 28, 2025
| referral_fee_info.referral_fee_ppm, | ||
| ); | ||
|
|
||
| let referral_fee_bps = |
Contributor
There was a problem hiding this comment.
maybe the TODO note about deleting this should live here...
Contributor
Author
There was a problem hiding this comment.
I think if we delete the other place, then the compiler will raise error and we'll delete this as well
| ); | ||
|
|
||
| let referral_fee_bps = | ||
| u16::try_from(referral_fee_info.referral_fee_ppm / FEE_BPS_TO_PPM) |
Contributor
There was a problem hiding this comment.
this should technically be ceiling divide, right?
Contributor
Author
There was a problem hiding this comment.
I'm not sure about this. Hopefully this will never happen, but I prefer less fees during conversions. Is it gonna produce bug anywhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add referral fee ppm to auction server quote apis