fix(hip-3-pusher): SEDA client optimization, pusher error fix, dev dependency fix (#3486)

Author: merolish

apps/hip-3-pusher/src/pusher/hermes_listener.py

@@ -4,7 +4,7 @@
 
 import websockets
 from loguru import logger
-from tenacity import retry, retry_if_exception_type, stop_after_attempt, wait_fixed
+from tenacity import retry, retry_if_exception_type, wait_fixed
 from websockets import ClientConnection
 
 from pusher.config import STALE_TIMEOUT_SECONDS, Config

apps/hip-3-pusher/src/pusher/hyperliquid_listener.py

@@ -27,7 +27,7 @@
 
 import websockets
 from loguru import logger
-from tenacity import retry, retry_if_exception_type, stop_after_attempt, wait_fixed
+from tenacity import retry, retry_if_exception_type, wait_fixed
 
 from pusher.config import STALE_TIMEOUT_SECONDS, Config
 from pusher.exception import StaleConnectionError

apps/hip-3-pusher/src/pusher/kms_signer.py

@@ -1,5 +1,5 @@
 from pathlib import Path
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import boto3
 from cryptography.hazmat.primitives import serialization
@@ -19,7 +19,11 @@
     l1_payload,
 )
 from loguru import logger
-from mypy_boto3_kms import KMSClient
+
+if TYPE_CHECKING:
+    from mypy_boto3_kms import KMSClient
+else:
+    KMSClient = Any
 
 from pusher.config import Config
 from pusher.exception import PushError

apps/hip-3-pusher/src/pusher/lazer_listener.py

@@ -4,7 +4,7 @@
 
 import websockets
 from loguru import logger
-from tenacity import retry, retry_if_exception_type, stop_after_attempt, wait_fixed
+from tenacity import retry, retry_if_exception_type, wait_fixed
 from websockets import ClientConnection
 
 from pusher.config import STALE_TIMEOUT_SECONDS, Config

apps/hip-3-pusher/src/pusher/publisher.py

@@ -176,8 +176,11 @@ async def publish(self) -> None:
                         external_perp_pxs=external_perp_pxs,
                     )
                 self._handle_response(push_response, list(oracle_pxs.keys()))
-            except PushError:
-                # since rate limiting is expected, don't necessarily log
+            except PushError as e:
+                logger.exception("Push API call failed: {}", repr(e))
+                self._update_attempts_total(
+                    "error", PushErrorReason.INTERNAL_ERROR, list(oracle_pxs.keys())
+                )
                 pass
             except Exception as e:
                 logger.exception("Unexpected exception in push request: {}", repr(e))

apps/hip-3-pusher/src/pusher/seda_listener.py

@@ -115,21 +115,23 @@ async def run(self) -> None:
             logger.info("No SEDA feeds needed")
             return
 
-        await asyncio.gather(
-            *[
-                self._run_single(feed_name, self.feeds[feed_name])
-                for feed_name in self.feeds
-            ]
-        )
+        async with httpx.AsyncClient(timeout=self.poll_timeout) as client:
+            await asyncio.gather(
+                *[
+                    self._run_single(client, feed_name, self.feeds[feed_name])
+                    for feed_name in self.feeds
+                ]
+            )
 
-    async def _run_single(self, feed_name: str, feed_config: SedaFeedConfig) -> None:
+    async def _run_single(
+        self, client: httpx.AsyncClient, feed_name: str, feed_config: SedaFeedConfig
+    ) -> None:
         """Run continuous polling loop for a single feed."""
-        async with httpx.AsyncClient(timeout=self.poll_timeout) as client:
-            while True:
-                result = await self.poll_single_feed(client, feed_name, feed_config)
-                await asyncio.sleep(
-                    self.poll_interval if result["ok"] else self.poll_failure_interval
-                )
+        while True:
+            result = await self.poll_single_feed(client, feed_name, feed_config)
+            await asyncio.sleep(
+                self.poll_interval if result["ok"] else self.poll_failure_interval
+            )
 
     async def poll_single_feed(
         self,
@@ -172,6 +174,7 @@ async def _poll(
         data: dict[str, Any],
     ) -> PollResult:
         """Execute HTTP POST request to SEDA API."""
+        resp: httpx.Response | None = None
         try:
             resp = await client.post(
                 self.url, headers=headers, params=params, json=data
@@ -182,6 +185,9 @@ async def _poll(
             return {"ok": False, "status": e.response.status_code, "error": repr(e)}
         except Exception as e:
             return {"ok": False, "status": None, "error": repr(e)}
+        finally:
+            if resp is not None:
+                await resp.aclose()
 
     def _parse_seda_message(self, feed_name: str, message: dict[str, Any]) -> None:
         """Parse SEDA response and store prices in state."""