fix(xc_admin): rethrow caught error instead of empty Error#3621
Open
dhruvja wants to merge 1 commit intopyth-network:mainfrom
Open
fix(xc_admin): rethrow caught error instead of empty Error#3621dhruvja wants to merge 1 commit intopyth-network:mainfrom
dhruvja wants to merge 1 commit intopyth-network:mainfrom
Conversation
|
@dhruvja is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The change replaces throw new Error(); with throw err; in the top-level catch of both crank scripts.
Rationale
throw new Error()creates a brand-new Error with no message and a stack trace that points at line 63 (or 231) which is at the re-throw itself, not at where the failure actually happened.console.error(err)prints it to stderr first, but Node's eventual "uncaught exception" report shows the thrown error which is the empty one.throw new Error()instead of the real RPC timeout / auth failure / malformed VAA / whatever triggered it.throw err;preserves the original error message, stack, and any properties like cause. Node reports the real failure in its crash output, so root-causing a production incident is one less instead of a forensic dig.How has this been tested?