Skip to content

fix(contract_manager): rethrow unhandled rejections, fix p-cancelable typo#3623

Open
dhruvja wants to merge 1 commit intopyth-network:mainfrom
dhruvja:fix/unhandled-rejection-rethrow
Open

fix(contract_manager): rethrow unhandled rejections, fix p-cancelable typo#3623
dhruvja wants to merge 1 commit intopyth-network:mainfrom
dhruvja:fix/unhandled-rejection-rethrow

Conversation

@dhruvja
Copy link
Copy Markdown

@dhruvja dhruvja commented Apr 22, 2026

Summary

Two small fixes in sync_wormhole_guardian_set.ts:

  • The unhandledRejection handler only filters out the p-cancelable race error and falls through with no re-throw, silently swallowing every other rejection. The sister uncaughtException handler re-throws non-matching errors; mirror that behavior so unexpected failures crash loudly.
  • Rename isPancelableRaceError → isPCancelableRaceError (the underlying library is https://github.com/sindresorhus/p-cancelable).

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 22, 2026

@dhruvja is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel Bot temporarily deployed to Preview – proposals April 22, 2026 07:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant