Skip to content

fix(contract_manager): rethrow unhandled rejections, fix p-cancelable typo #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruvja wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

fix(contract_manager): rethrow unhandled rejections, fix p-cancelable typo #3623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contract_manager/scripts/sync_wormhole_guardian_set.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const GUARDIAN_INDEX_TIMEOUT_MS = 10_000;
const SYNC_GUARDIAN_SETS_TIMEOUT_MS = 3 * 60 * 1000;

/** Suppress got/p-cancelable race when our timeout fires before the request settles. */
function isPancelableRaceError(err: unknown): boolean {
function isPCancelableRaceError(err: unknown): boolean {
return (
err instanceof Error &&
err.message.includes("onCancel") &&
Expand All @@ -21,10 +21,11 @@ function isPancelableRaceError(err: unknown): boolean {
}

process.on("unhandledRejection", (reason: unknown) => {
if (isPancelableRaceError(reason)) return;
if (isPCancelableRaceError(reason)) return;
throw reason;
});
process.on("uncaughtException", (err: Error) => {
if (isPancelableRaceError(err)) return;
if (isPCancelableRaceError(err)) return;
throw err;
});

Expand Down