feat(price_pusher): exponential backoff for Hermes reconnect#3624
Open
dhruvja wants to merge 1 commit intopyth-network:mainfrom
Open
feat(price_pusher): exponential backoff for Hermes reconnect#3624dhruvja wants to merge 1 commit intopyth-network:mainfrom
dhruvja wants to merge 1 commit intopyth-network:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
@dhruvja is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Hermes
onerrorhandler inPythPriceListenerretried with a flat 5-second delay and fire-and-forgetvoid this.startListening(), which has two problems:getPriceUpdatesStream) rejects, it becomes an unhandled rejection.This extracts the reconnect into a
reconnectWithBackoffmethod that doubles its delay (1s → 30s cap) on each failed attempt, routes errors through the pino logger, and catches reconnect-time failures so they feed the next iteration instead of going unhandled. The existing healthcheck (which throws after 30s of no updates) still bounds the worst case.
How has this been tested?