Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 5 potential issues.
⚠️ 1 issue in files not directly in the diff
⚠️ Accidental empty output.txt file committed to repository (target_chains/solana/programs/core-bridge/output.txt:1)
An empty output.txt file is added to target_chains/solana/programs/core-bridge/output.txt. This looks like an accidental file from a build or debug session. Per REVIEW.md: "Check for files that should not be in the repo (e.g., generated files, .env files, credentials, documents/). Flag any suspicious additions."
View 4 additional findings in Devin Review.
There was a problem hiding this comment.
🚩 Vendoring entire core-bridge program is a large addition — scope and test coverage
This PR vendors the entire Wormhole Core Bridge program (~4000+ lines of Rust) as a local dependency, replacing a git dependency. Per REVIEW.md's scope discipline rule, this is a very large addition. The commit message is simply "go", which provides no context. There are no tests included in this PR for the new code, and the README.md is empty. While the core-bridge code may have been tested upstream, the vendored version should have at minimum integration tests to verify it works correctly with the existing pyth-solana-receiver.
Was this helpful? React with 👍 or 👎 to provide feedback.
2 participants
I would like to bring this contract over from https://github.com/guibescos/wormhole/tree/feat/add-update-guardian-set-ttl/solana/programs/core-bridge, now that we are going to do more work on it.
This is the wormhole receiver that we use on Solana and SVM chains.
This PR is basically just a copy paste, with minimal changes to:
target_chains/solanaworkspace alongside the Pyth contracts