Skip to content

Commit c903523

Browse files
committed
modify filenames and version-module import from setup.py
Remove usage of deprecated 'imp' module in favour of 'importlib'. Also remove the package name from as many places as possible.
1 parent ab6c611 commit c903523

5 files changed

Lines changed: 21 additions & 14 deletions

File tree

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
*.ipynb filter=nbclearoutput
2-
adaptive/_adaptive_version.py export-subst
2+
adaptive/_static_version.py export-subst

adaptive/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
from .learner import (Learner1D, Learner2D, AverageLearner,
99
BalancingLearner, DataSaver, IntegratorLearner)
1010
from .runner import Runner, BlockingRunner
11-
from . import _version
11+
from . import version
1212

13-
__version__ = _version.version
13+
__version__ = version.version
1414

1515
del notebook_integration # to avoid confusion with `notebook_extension`
16-
del _version
16+
del version
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This file will be overwritten by setup.py when a source or binary
22
# distribution is made. The magic value "__use_git__" is interpreted by
3-
# _version.py in this directory.
3+
# version.py.
44

55
version = "__use_git__"
66

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
package_root = os.path.dirname(os.path.realpath(__file__))
99
distr_root = os.path.dirname(package_root)
1010

11-
STATIC_VERSION_FILE = '_adaptive_version.py'
11+
STATIC_VERSION_FILE = '_static_version.py'
1212

1313
version = None
1414

setup.py

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33

44
import os
55
import sys
6-
import imp
6+
import importlib
7+
from importlib.util import module_from_spec, spec_from_file_location
78
from setuptools import setup, find_packages
89
from setuptools.command.sdist import sdist as sdist_orig
910
from distutils.command.build import build as build_orig
@@ -14,10 +15,17 @@
1415
sys.exit(1)
1516

1617

17-
# Load _version.py module without importing 'adaptive'
18-
_dont_write_bytecode = sys.dont_write_bytecode
19-
version = imp.load_source('version', 'adaptive/_version.py')
20-
sys.dont_write_bytecode = _dont_write_bytecode
18+
package_name = 'adaptive'
19+
20+
# Load version.py module without importing 'adaptive'
21+
def load_version_module():
22+
spec = spec_from_file_location('version',
23+
'{}/version.py'.format(package_name))
24+
module = module_from_spec(spec)
25+
spec.loader.exec_module(module)
26+
return module
27+
28+
version = load_version_module()
2129

2230

2331
def write_version(fname):
@@ -35,15 +43,14 @@ def write_version(fname):
3543
class build(build_orig):
3644
def run(self):
3745
super().run()
38-
write_version(os.path.join(self.build_lib, 'adaptive',
46+
write_version(os.path.join(self.build_lib, package_name,
3947
version.STATIC_VERSION_FILE))
4048

4149

4250
class sdist(sdist_orig):
43-
4451
def make_release_tree(self, base_dir, files):
4552
super().make_release_tree(base_dir, files)
46-
write_version(os.path.join(base_dir, 'adaptive',
53+
write_version(os.path.join(base_dir, package_name,
4754
version.STATIC_VERSION_FILE))
4855

4956

0 commit comments

Comments
 (0)