add checks for volume consistency

Author: jhoofwijk

adaptive/learner/triangulation.py

@@ -520,6 +520,10 @@ def bowyer_watson(self, pt_index, containing_simplex=None, transform=None):
         deleted_simplices = bad_triangles - new_triangles
         new_simplices = new_triangles - bad_triangles
 
+        old_vol = sum([self.volume(simplex) for simplex in deleted_simplices])
+        new_vol = sum([self.volume(simplex) for simplex in new_simplices])
+        assert np.isclose(old_vol, new_vol), f"{old_vol} !== {new_vol}"
+
         return deleted_simplices, new_simplices
 
     def add_point(self, point, simplex=None, transform=None):

adaptive/tests/test_learnernd.py

@@ -1,10 +1,17 @@
 # -*- coding: utf-8 -*-
 
 from ..learner import LearnerND
-from ..runner import replay_log
+from ..runner import replay_log, BlockingRunner
+import numpy as np
 
 
-def test_faiure_case_LearnerND():
+def sphere(xyz):
+    x, y, z = xyz
+    a = 0.4
+    return x + z**2 + np.exp(-(x**2 + y**2 + z**2 - 0.75**2)**2/a**4)
+
+
+def test_failure_case_LearnerND():
     log = [
         ('ask', 4),
         ('tell', (-1, -1, -1), 1.607873907219222e-101),
@@ -21,3 +28,18 @@ def test_faiure_case_LearnerND():
     ]
     learner = LearnerND(lambda *x: x, bounds=[(-1, 1), (-1, 1), (-1, 1)])
     replay_log(learner, log)
+
+
+def test_anisotropic_3d():
+    # there was this bug that the total volume would exceed the bounding box 
+    # volume for the anisotropic 3d learnerND
+    # learner = adaptive.LearnerND(ring, bounds=[(-1, 1), (-1, 1)], anisotropic=True)
+    learner = LearnerND(sphere, bounds=[(-1, 1), (-1, 1), (-1, 1)], anisotropic=True)
+    def goal(l):
+        if l.tri:
+            sum_of_simplex_volumes = np.sum(l.tri.volumes())
+            assert sum_of_simplex_volumes < 8.00000000001
+        return l.npoints >= 1000
+    BlockingRunner(learner, goal, ntasks=1)
+
+    assert learner.npoints >= 1000