-
-
Notifications
You must be signed in to change notification settings - Fork 137
Fix type resolution #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix type resolution #662
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9cbbf8b
Add test for type resolution using generics and forward references
AdrianSosic 05d823b
Fix type resolution call
AdrianSosic e777bca
Add assert statement
AdrianSosic 5467a2a
Avoid unnecessary import
AdrianSosic 839bd97
Adjust docstring
AdrianSosic 729afed
Update changelog
AdrianSosic fcbe668
Rename test
AdrianSosic dafd559
Add structuring operation to test
AdrianSosic 7e4196b
Add full stop to changelog
AdrianSosic 967155c
Rename forwardrefs.py to generics.py
AdrianSosic 414799b
Put everything under test_generics_649.py
AdrianSosic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| """Class definitions using forward references.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import Generic, TypeVar | ||
|
|
||
| from attrs import define | ||
|
|
||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| @define | ||
| class GenericClass(Generic[T]): | ||
| t: T |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.