addressing copilot comments

Author: shaypal5

src/cachier/cores/sql.py

@@ -120,8 +120,9 @@ def set_entry(self, key: str, func_res: Any) -> None:
         with self._lock, self._Session() as session:
             thebytes = pickle.dumps(func_res)
             now = datetime.now()
+            base_insert = insert(CacheTable)
             stmt = (
-                insert(CacheTable)
+                base_insert
                 .values(
                     id=f"{self._func_str}:{key}",
                     function_id=self._func_str,
@@ -142,7 +143,7 @@ def set_entry(self, key: str, func_res: Any) -> None:
                         "completed": True,
                     },
                 )
-                if hasattr(insert(CacheTable), "on_conflict_do_update")
+                if hasattr(base_insert, "on_conflict_do_update")
                 else None
             )
             # Fallback for non-SQLite/Postgres: try update, else insert

tests/test_sql_core.py

@@ -254,22 +254,20 @@ def test_sqlcore_get_entry_by_key_none_value():
 
 @pytest.mark.sql
 def test_sqlcore_set_entry_fallback(monkeypatch):
+    from sqlalchemy.orm import Session
     core = _SQLCore(hash_func=None, sql_engine=SQL_CONN_STR)
     core.set_func(lambda x: x)
-    # Monkeypatch insert to not have on_conflict_do_update
-    orig_insert = core._Session().execute
-
-    def fake_insert(stmt):
+    # Monkeypatch Session.execute to simulate fallback path
+    orig_execute = Session.execute
+    def fake_execute(self, stmt, *args, **kwargs):
         class FakeInsert:
             def __init__(self):
                 pass
-
         return FakeInsert()
-
-    monkeypatch.setattr(core._Session(), "execute", fake_insert)
+    monkeypatch.setattr(Session, "execute", fake_execute)
     # Should not raise
     core.set_entry("fallback", 123)
-    monkeypatch.setattr(core._Session(), "execute", orig_insert)
+    monkeypatch.setattr(Session, "execute", orig_execute)
 
 
 @pytest.mark.sql