more linting nightmare

Author: shaypal5

pyproject.toml

@@ -140,8 +140,9 @@ lint.unfixable = [
 # Unlike Flake8, default to a complexity level of 10.
 lint.mccabe.max-complexity = 10
 
+# --- flake8 ---
 [tool.flake8]
-ignore = [ "C901", "E203", "W503" ]
+ignore = [ "C901", "E203", "W503", "F824" ]
 exclude = [
   ".git",
   ".github",
@@ -177,7 +178,6 @@ exclude-too-few-public-methods = [ ".+" ]
 [tool.pylint.'MESSAGES CONTROL']
 disable = [ "R0911", "R0913", "R0903" ]
 
-# --- flake8 ---
 
 [tool.docformatter]
 recursive = true

src/cachier/_version.py

@@ -18,7 +18,8 @@
 def _get_git_sha() -> str:
     from subprocess import DEVNULL, check_output
 
-    out = check_output(["git", "rev-parse", "--short", "HEAD"], stderr=DEVNULL)  # noqa: S603, S607
+    args = ["git", "rev-parse", "--short", "HEAD"]
+    out = check_output(args, stderr=DEVNULL)  # noqa: S603, S607
     return out.decode("utf-8").strip()
 
 

src/cachier/cores/mongo.py

@@ -75,7 +75,9 @@ def get_entry_by_key(self, key: str) -> Tuple[str, Optional[CacheEntry]]:
         )
         if not res:
             return key, None
-        val = pickle.loads(res["value"]) if "value" in res else None  # noqa: S301
+        val = None
+        if "value" in res:
+            val = pickle.loads(res["value"])  # noqa: S301
         entry = CacheEntry(
             value=val,
             time=res.get("time", None),

tests/test_general.py

@@ -485,9 +485,9 @@ def fn_minus(a, b=2):
         assert cachier_(dummy_)(1) == expected, f"for {fn.__name__} wrapped"
 
         dummy_ = functools.partial(fn, b=2)
-        assert cachier_(dummy_)(1, b=2) == expected, (
-            f"for {fn.__name__} wrapped"
-        )
+        assert (
+            cachier_(dummy_)(1, b=2) == expected
+        ), f"for {fn.__name__} wrapped"
 
         assert cachier_(fn)(1, 2) == expected, f"for {fn.__name__} inline"
         assert cachier_(fn)(a=1, b=2) == expected, f"for {fn.__name__} inline"