Refactor: rename set_entry to _set_entry, refine size-limit logic, and add metric for size-limit rejections

Author: Borda

src/cachier/cores/base.py

@@ -129,9 +129,12 @@ def _should_store(self, value: Any) -> bool:
         if self.entry_size_limit is None:
             return True
         try:
-            return self._estimate_size(value) <= self.entry_size_limit
+            should_store = self._estimate_size(value) <= self.entry_size_limit
         except Exception:
             return True
+        if not should_store and self.metrics is not None:
+            self.metrics.record_size_limit_rejection()
+        return should_store
 
     def _update_size_metrics(self) -> None:
         """Update cache size metrics if metrics are enabled.

src/cachier/metrics.py

@@ -252,7 +252,7 @@ def _calculate_avg_latency(self, window: Optional[timedelta] = None) -> float:
         """
         # Use monotonic clock for cutoff calculation
         now = time.perf_counter()
-        cutoff = 0.0 if window is None else now - window.total_seconds()
+        cutoff = 0.0 if not window else now - window.total_seconds()
 
         latencies = [metric.value for metric in self._latencies if metric.timestamp >= cutoff]
 
@@ -377,3 +377,8 @@ def record_wait_timeout(self) -> None:
         """Record a wait timeout."""
         if self._m:
             self._m.record_wait_timeout()
+
+    def record_size_limit_rejection(self) -> None:
+        """Record an entry rejection due to size limit."""
+        if self._m:
+            self._m.record_size_limit_rejection()

tests/test_base_core.py

@@ -26,7 +26,7 @@ def get_entry_by_key(self, key, reload=False):
         """Retrieve an entry by its key."""
         return key, None
 
-    def set_entry(self, key, func_res):
+    def _set_entry(self, key, func_res):
         """Store an entry in the cache."""
         self.last_set = (key, func_res)
         return True