pre-commit fixes

Author: shaypal5

tests/test_coverage_gaps.py

@@ -1,17 +1,14 @@
 """Tests to cover specific coverage gaps identified in the codebase."""
 
-import os
-import pickle
+import contextlib
 import sys
-import tempfile
 import time
-from datetime import datetime, timedelta
-from unittest.mock import Mock, patch
+from datetime import timedelta
+from unittest.mock import patch
 
 import pytest
 
 import cachier
-from cachier.config import CacheEntry, _global_params
 
 # Import backend-specific test helpers
 from tests.test_mongo_core import _test_mongetter
@@ -43,15 +40,18 @@ def returns_none():
 
 
 # Test 3: MongoDB delete_stale_entries (lines 162-163)
-# Removed - redundant with test_mongo_delete_stale_direct in test_coverage_gaps_simple.py
+# Removed - redundant with test_mongo_delete_stale_direct in
+# test_coverage_gaps_simple.py
 
 
 # Test 4: Pickle _clear_being_calculated_all_cache_files (lines 183-189)
-# Removed - redundant with test_pickle_clear_being_calculated_separate_files in test_coverage_gaps_simple.py
+# Removed - redundant with test_pickle_clear_being_calculated_separate_files in
+# test_coverage_gaps_simple.py
 
 
 # Test 5: Pickle save_cache with hash_str (line 205)
-# Removed - redundant with test_pickle_save_with_hash_str in test_coverage_gaps_simple.py
+# Removed - redundant with test_pickle_save_with_hash_str in
+# test_coverage_gaps_simple.py
 
 
 # Test 6: Redis import error handling (lines 14-15)
@@ -65,14 +65,13 @@ def test_redis_import_error_handling():
         if "cachier.cores.redis" in sys.modules:
             del sys.modules["cachier.cores.redis"]
 
+        # Test import failure
         try:
-            from cachier.cores.redis import _RedisCore
+            from cachier.cores.redis import _RedisCore  # noqa: F401
 
-            # If we get here, redis was imported successfully (shouldn't happen in test)
             pytest.skip("Redis is installed, cannot test import error")
-        except ImportError as e:
-            # This is expected - verify the error message
-            assert "No module named 'redis'" in str(e) or "redis" in str(e)
+        except ImportError:
+            pass  # Expected behavior
 
 
 # Test 7: Redis corrupted entry handling (lines 112-114)
@@ -161,11 +160,13 @@ def mock_delete(*args):
 
 
 # Test 9: SQL allow_none=False handling (line 128)
-# Removed - redundant with test_sql_allow_none_false_not_stored in test_coverage_gaps_simple.py
+# Removed - redundant with test_sql_allow_none_false_not_stored in
+# test_coverage_gaps_simple.py
 
 
 # Test 10: SQL delete_stale_entries (lines 302-312)
-# Removed - redundant with test_sql_delete_stale_direct in test_coverage_gaps_simple.py
+# Removed - redundant with test_sql_delete_stale_direct in
+# test_coverage_gaps_simple.py
 
 
 # Test 11: Pickle timeout during wait (line 398)
@@ -220,7 +221,8 @@ def call_slow_func():
 
 
 # Test 12: Redis stale deletion with cache size tracking (lines 374-375, 380)
-# Removed - redundant with test_redis_stale_delete_size_tracking in test_coverage_gaps_simple.py
+# Removed - redundant with test_redis_stale_delete_size_tracking in
+# test_coverage_gaps_simple.py
 
 
 # Test 13: Redis non-bytes timestamp handling (line 364)
@@ -266,10 +268,9 @@ def test_func(x):
     )
     core.set_func(test_func)
 
-    # Try to delete stale entries - should handle non-bytes timestamp gracefully
-    try:
+    # Try to delete stale entries - should handle non-bytes timestamp
+    # gracefully
+    with contextlib.suppress(Exception):
         core.delete_stale_entries(timedelta(seconds=1))
-    except Exception:
-        pass  # Expected to handle gracefully
 
     test_func.clear_cache()

tests/test_coverage_gaps_simple.py

@@ -1,11 +1,9 @@
 """Simple tests to cover specific coverage gaps."""
 
 import os
-import sys
 import tempfile
 import time
 from datetime import datetime, timedelta
-from unittest.mock import Mock, patch
 
 import pytest
 
@@ -116,7 +114,7 @@ def test_func(x):
     from cachier.cores.mongo import _MongoCore
 
     # Get the collection
-    collection = _test_mongetter()
+    _test_mongetter()  # Ensure connection is available
 
     # Create a core instance just for deletion
     core = _MongoCore(
@@ -299,17 +297,14 @@ def test_redis_import_error():
     # Test creating a Redis core without providing a client
     import warnings
 
-    with warnings.catch_warnings(record=True) as w:
+    with warnings.catch_warnings(record=True):
         warnings.simplefilter("always")
 
-        try:
+        with pytest.raises(Exception, match="redis_client"):
 
             @cachier.cachier(backend="redis", redis_client=None)
             def test_func():
                 return "test"
-        except Exception as e:
-            # Expected to fail with MissingRedisClient
-            assert "redis_client" in str(e)
 
 
 # Test 9: Redis corrupted entry in LRU eviction