more fixes

Author: shaypal5

pyproject.toml

@@ -126,6 +126,7 @@ lint.per-file-ignores."tests/**" = [
   "S311",
   "S603",
 ]
+lint.per-file-ignores."src/cachier/cores/sql.py" = ["S301"]
 lint.unfixable = [
   "F401",
 ]

src/cachier/_version.py

@@ -18,7 +18,9 @@
 def _get_git_sha() -> str:
     from subprocess import DEVNULL, check_output
 
-    out = check_output(["git", "rev-parse", "--short", "HEAD"], stderr=DEVNULL)  # noqa: S603, S607
+    out = check_output(
+        ["git", "rev-parse", "--short", "HEAD"], stderr=DEVNULL
+    )  # noqa: S603, S607
     return out.decode("utf-8").strip()
 
 

src/cachier/cores/base.py

@@ -1,4 +1,5 @@
 """Defines the interface of a cachier caching core."""
+
 # This file is part of Cachier.
 # https://github.com/python-cachier/cachier
 

src/cachier/cores/mongo.py

@@ -75,7 +75,9 @@ def get_entry_by_key(self, key: str) -> Tuple[str, Optional[CacheEntry]]:
         )
         if not res:
             return key, None
-        val = pickle.loads(res["value"]) if "value" in res else None  # noqa: S301
+        val = (
+            pickle.loads(res["value"]) if "value" in res else None
+        )  # noqa: S301
         entry = CacheEntry(
             value=val,
             time=res.get("time", None),

src/cachier/cores/sql.py

@@ -42,6 +42,8 @@
     Base = declarative_base()
 
     class CacheTable(Base):
+        """SQLAlchemy model for cachier cache entries."""
+
         __tablename__ = "cachier_cache"
         id = Column(String, primary_key=True)
         function_id = Column(String, index=True, nullable=False)
@@ -57,8 +59,10 @@ class CacheTable(Base):
 
 
 class _SQLCore(_BaseCore):
-    """SQLAlchemy-based core for Cachier, supporting SQLite, PostgreSQL, MySQL,
-    etc.
+    """SQLAlchemy-based core for Cachier, supporting SQL-based backends.
+
+    This should work with SQLite, PostgreSQL and so on.
+
     """
 
     def __init__(

tests/test_general.py

@@ -485,9 +485,9 @@ def fn_minus(a, b=2):
         assert cachier_(dummy_)(1) == expected, f"for {fn.__name__} wrapped"
 
         dummy_ = functools.partial(fn, b=2)
-        assert cachier_(dummy_)(1, b=2) == expected, (
-            f"for {fn.__name__} wrapped"
-        )
+        assert (
+            cachier_(dummy_)(1, b=2) == expected
+        ), f"for {fn.__name__} wrapped"
 
         assert cachier_(fn)(1, 2) == expected, f"for {fn.__name__} inline"
         assert cachier_(fn)(a=1, b=2) == expected, f"for {fn.__name__} inline"

tests/test_sql_core.py

@@ -144,6 +144,10 @@ def f(x):
     assert f(123) == 123
 
 
+class DummyWriteError(Exception):
+    pass
+
+
 @pytest.mark.sql
 def test_sql_failed_write(monkeypatch):
     @cachier(backend="sql", sql_engine=SQL_CONN_STR)
@@ -155,10 +159,10 @@ def f(x):
     orig = _SQLCore.set_entry
 
     def fail_set_entry(self, key, func_res):
-        raise Exception("fail")
+        raise DummyWriteError("fail")
 
     monkeypatch.setattr(_SQLCore, "set_entry", fail_set_entry)
-    with pytest.raises(Exception):
+    with pytest.raises(DummyWriteError, match="fail"):
         f(1)
     monkeypatch.setattr(_SQLCore, "set_entry", orig)