Remove mypy usage and add size util

Author: shaypal5

.github/copilot-instructions.md

@@ -26,7 +26,7 @@ Welcome to the Cachier codebase! Please follow these guidelines to ensure code s
 
 ## 4. Coverage, Linting, and Typing
 
-- Code must pass `mypy`, `ruff`, and `pytest`.
+- Code must pass `ruff` and `pytest`.
 - Use per-file or per-line ignores for known, justified issues (e.g., SQLAlchemy model base class typing, intentional use of `pickle`).
 - All new code must include full type annotations and docstrings matching the style of the existing codebase.
 - All docstrings should follow numpy docstring conventions.

.pre-commit-config.yaml

@@ -65,12 +65,6 @@ repos:
         name: Ruff check
         args: ["--fix"]
 
-  # it needs to be after formatting hooks because the lines might be changed
-  - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.16.1
-    hooks:
-      - id: mypy
-        files: "src/*"
 
   - repo: https://github.com/tox-dev/pyproject-fmt
     rev: v2.6.0

AGENTS.md

@@ -9,7 +9,6 @@
 - **Key Dependencies:** `portalocker`, `watchdog` (optional: `pymongo`, `sqlalchemy`, `redis`)
 - **Test Framework:** `pytest` with backend-specific markers
 - **Linting:** `ruff` (replaces black/flake8)
-- **Type Checking:** `mypy`
 - **CI:** GitHub Actions (matrix for backends/OS with Dockerized services)
 - **Issue Tracking:** GitHub Issues
 - **Additional Docs:** `.github/copilot-instructions.md` for contributor guidelines
@@ -65,11 +64,10 @@ ______________________________________________________________________
    pytest -m "not (mongo or sql)"  # Exclude external service backends
    ```
 
-3. **Lint and type-check:**
+3. **Lint:**
 
    ```bash
    ruff check .
-   mypy src/cachier/
    ```
 
 4. **Try an example:**
@@ -102,7 +100,6 @@ ______________________________________________________________________
 - **Type annotations** required for all new code.
 - **Docstrings:** Use numpy style, multi-line, no single-line docstrings.
 - **Lint:** Run `ruff` before PRs. Use per-line/file ignores only for justified cases.
-- **Type check:** Run `mypy` before PRs.
 - **Testing:** All public methods must have at least one test. Use `pytest.mark.<backend>` for backend-specific tests.
 - **No warnings/errors for missing optional dependencies at import time.** Only raise when backend is used.
 
@@ -415,7 +412,6 @@ ______________________________________________________________________
 - **Run multiple backends:** `pytest -m "redis or sql"`
 - **Exclude backends:** `pytest -m "not mongo"`
 - **Lint:** `ruff check .`
-- **Type check:** `mypy src/cachier/`
 - **Format:** `ruff format .`
 - **Pre-commit:** `pre-commit run --all-files`
 - **Build package:** `python -m build`
@@ -505,7 +501,6 @@ ______________________________________________________________________
 - **If adding new dependencies, use context7 MCP to get latest versions.**
 - **Always check GitHub Issues before starting new features/PRs.**
 - **Create a relevant issue for every new PR.**
-- **Use per-file or per-line ignores for mypy/ruff only when justified.**
 - **All new code must have full type annotations and numpy-style docstrings.**
 
 ______________________________________________________________________
@@ -557,7 +552,6 @@ ______________________________________________________________________
 | Test multiple backends     | `pytest -m "redis or sql"`         |
 | Exclude backends           | `pytest -m "not mongo"`            |
 | Lint                       | `ruff check .`                     |
-| Type check                 | `mypy src/cachier/`                |
 | Format code                | `ruff format .`                    |
 | Build package              | `python -m build`                  |
 | Check docs                 | `python setup.py checkdocs`        |

CLAUDE.md

@@ -9,7 +9,6 @@
 - **Key Dependencies:** `portalocker`, `watchdog` (optional: `pymongo`, `sqlalchemy`, `redis`)
 - **Test Framework:** `pytest` with backend-specific markers
 - **Linting:** `ruff` (replaces black/flake8)
-- **Type Checking:** `mypy`
 - **CI:** GitHub Actions (matrix for backends/OS with Dockerized services)
 - **Issue Tracking:** GitHub Issues
 - **Additional Docs:** `.github/copilot-instructions.md` for contributor guidelines
@@ -69,7 +68,6 @@ ______________________________________________________________________
 
    ```bash
    ruff check .
-   mypy src/cachier/
    ```
 
 4. **Try an example:**
@@ -102,7 +100,6 @@ ______________________________________________________________________
 - **Type annotations** required for all new code.
 - **Docstrings:** Use numpy style, multi-line, no single-line docstrings.
 - **Lint:** Run `ruff` before PRs. Use per-line/file ignores only for justified cases.
-- **Type check:** Run `mypy` before PRs.
 - **Testing:** All public methods must have at least one test. Use `pytest.mark.<backend>` for backend-specific tests.
 - **No warnings/errors for missing optional dependencies at import time.** Only raise when backend is used.
 
@@ -415,7 +412,6 @@ ______________________________________________________________________
 - **Run multiple backends:** `pytest -m "redis or sql"`
 - **Exclude backends:** `pytest -m "not mongo"`
 - **Lint:** `ruff check .`
-- **Type check:** `mypy src/cachier/`
 - **Format:** `ruff format .`
 - **Pre-commit:** `pre-commit run --all-files`
 - **Build package:** `python -m build`
@@ -505,7 +501,6 @@ ______________________________________________________________________
 - **If adding new dependencies, use context7 MCP to get latest versions.**
 - **Always check GitHub Issues before starting new features/PRs.**
 - **Create a relevant issue for every new PR.**
-- **Use per-file or per-line ignores for mypy/ruff only when justified.**
 - **All new code must have full type annotations and numpy-style docstrings.**
 
 ______________________________________________________________________
@@ -557,7 +552,6 @@ ______________________________________________________________________
 | Test multiple backends     | `pytest -m "redis or sql"`         |
 | Exclude backends           | `pytest -m "not mongo"`            |
 | Lint                       | `ruff check .`                     |
-| Type check                 | `mypy src/cachier/`                |
 | Format code                | `ruff format .`                    |
 | Build package              | `python -m build`                  |
 | Check docs                 | `python setup.py checkdocs`        |

Makefile

@@ -5,7 +5,7 @@
         test-mongo-local test-mongo-docker test-mongo-inmemory test-mongo-also-local \
         test-redis-local test-sql-local \
         services-start services-stop services-logs \
-        mongo-start mongo-stop mongo-logs lint type-check format clean \
+mongo-start mongo-stop mongo-logs lint format clean \
         install install-dev install-all
 
 # Default target
@@ -30,7 +30,6 @@ help:
 	@echo ""
 	@echo "Code Quality:"
 	@echo "  make lint               - Run ruff linter"
-	@echo "  make type-check         - Run mypy type checker"
 	@echo "  make format             - Format code with ruff"
 	@echo ""
 	@echo "Installation:"
@@ -131,8 +130,6 @@ mongo-logs:
 lint:
 	ruff check .
 
-type-check:
-	mypy src/cachier/
 
 format:
 	ruff format .
@@ -145,7 +142,6 @@ clean:
 	rm -rf .coverage
 	rm -rf htmlcov/
 	rm -rf .pytest_cache/
-	rm -rf .mypy_cache/
 	rm -rf .ruff_cache/
 	find . -type d -name __pycache__ -exec rm -rf {} + 2>/dev/null || true
 	find . -type f -name "*.pyc" -delete

pyproject.toml

@@ -46,6 +46,7 @@ dynamic = [
 dependencies = [
   "portalocker>=2.3.2",
   "watchdog>=2.3.1",
+  "pympler>=1.0",
 ]
 urls.Source = "https://github.com/python-cachier/cachier"
 # --- setuptools ---
@@ -197,5 +198,5 @@ show_missing = true
 exclude_lines = [
   "pragma: no cover",          # Have to re-enable the standard pragma
   "raise NotImplementedError", # Don't complain if tests don't hit defensive assertion code:
-  "if TYPE_CHECKING:",         # Is only true when running mypy, not tests
+  "if TYPE_CHECKING:",
 ]

src/cachier/__init__.py

@@ -4,11 +4,11 @@
     enable_caching,
     get_default_params,
     get_global_params,
-    parse_bytes,
     set_default_params,
     set_global_params,
 )
 from .core import cachier
+from .util import parse_bytes
 
 __all__ = [
     "cachier",

src/cachier/config.py

@@ -1,7 +1,6 @@
 import hashlib
 import os
 import pickle
-import re
 import threading
 from dataclasses import dataclass, field, replace
 from datetime import datetime, timedelta
@@ -33,27 +32,6 @@ def _default_cache_dir():
     return os.path.expanduser("~/.cachier/")
 
 
-def parse_bytes(size: Union[int, str, None]) -> Optional[int]:
-    """Convert a human friendly size string to bytes."""
-    if size is None:
-        return None
-    if isinstance(size, int):
-        return size
-    match = re.fullmatch(r"(?i)\s*(\d+(?:\.\d+)?)\s*([kmgt]?b)?\s*", str(size))
-    if not match:
-        raise ValueError(f"Invalid size value: {size}")
-    number = float(match.group(1))
-    unit = (match.group(2) or "b").upper()
-    factor = {
-        "B": 1,
-        "KB": 1024,
-        "MB": 1024**2,
-        "GB": 1024**3,
-        "TB": 1024**4,
-    }[unit]
-    return int(number * factor)
-
-
 class LazyCacheDir:
     """Lazily resolve the default cache directory using $XDG_CACHE_HOME."""
 

src/cachier/core.py

@@ -19,19 +19,14 @@
 from warnings import warn
 
 from ._types import RedisClient
-from .config import (
-    Backend,
-    HashFunc,
-    Mongetter,
-    _update_with_defaults,
-    parse_bytes,
-)
+from .config import Backend, HashFunc, Mongetter, _update_with_defaults
 from .cores.base import RecalculationNeeded, _BaseCore
 from .cores.memory import _MemoryCore
 from .cores.mongo import _MongoCore
 from .cores.pickle import _PickleCore
 from .cores.redis import _RedisCore
 from .cores.sql import _SQLCore
+from .util import parse_bytes
 
 MAX_WORKERS_ENVAR_NAME = "CACHIER_MAX_WORKERS"
 DEFAULT_MAX_WORKERS = 8

src/cachier/cores/base.py

@@ -9,12 +9,13 @@
 
 import abc  # for the _BaseCore abstract base class
 import inspect
-import pickle
 import sys
 import threading
 from datetime import timedelta
 from typing import Any, Callable, Optional, Tuple
 
+from pympler import asizeof
+
 from .._types import HashFunc
 from ..config import CacheEntry, _update_with_defaults
 
@@ -96,7 +97,7 @@ def get_entry_by_key(self, key: str) -> Tuple[str, Optional[CacheEntry]]:
 
     def _estimate_size(self, value: Any) -> int:
         try:
-            return len(pickle.dumps(value))
+            return asizeof.asizeof(value)
         except Exception:
             return sys.getsizeof(value)