fix safety check and copilot instructions#265
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum Python version, replaces the security scan action, and adds Copilot custom instructions for the Cachier project.
- Bumps required Python version from 3.8 to 3.9 in the README.
- Switches the security vulnerabilities scanner to
aufdenpunkt/python-safety-check@v1.0.6. - Introduces a new Copilot instructions file with usage and review guidelines.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.rst | Updated Python compatibility to 3.9+. |
| .github/workflows/safety.yml | Replaced the safety scan action with aufdenpunkt/python-safety-check. |
| .github/copilot-instructions.md | Added GitHub Copilot custom instruction guidelines for Cachier. |
Comments suppressed due to low confidence (1)
README.rst:47
- [nitpick] Consider updating your CI/test matrices (e.g., GitHub Actions or Travis) to remove Python 3.8 entries and ensure they align with the new minimum Python 3.9 requirement.
* Compatible with Python 3.9+ (Python 2.7 was discontinued in version 1.2.8).
| uv pip compile pyproject.toml -o requirements.txt | ||
| - name: Security vulnerabilities scan | ||
| uses: shaypal5/python-safety-checker@v1.0.6 | ||
| uses: aufdenpunkt/python-safety-check@v1.0.6 |
There was a problem hiding this comment.
For stronger supply-chain security, pin this action to a specific commit SHA instead of a mutable tag to avoid unexpected upstream changes.
Suggested change
| uses: aufdenpunkt/python-safety-check@v1.0.6 | |
| uses: aufdenpunkt/python-safety-check@<commit-sha> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.