Skip to content

Fix codecov to work on PRs, and be used as a required check #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaypal5 merged 5 commits into from
Jul 17, 2025
Merged

Fix codecov to work on PRs, and be used as a required check #298

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6ba09d
pull_request_target should allow PR jobs to use secrets, enabling cod…
shaypal5 Jul 16, 2025
1721e8f
try to fix it
shaypal5 Jul 16, 2025
10ef6b9
try again
shaypal5 Jul 16, 2025
905cb5c
run on the test environment
shaypal5 Jul 16, 2025
ac3bb92
and again
shaypal5 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: Test
on:
pull_request:
branches: [master]
pull_request_target:
branches: [master]
push:
branches: [master]
schedule:
Expand All @@ -16,7 +18,10 @@ concurrency:

jobs:
pytester:
# run on both push & normal PR
if: github.event_name == 'push' || github.event_name == 'pull_request'
runs-on: ${{ matrix.os }}
environment: test
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -144,25 +149,14 @@ jobs:
if: matrix.backend == 'redis'
run: pytest -m redis --cov=cachier --cov-report=term --cov-report=xml:cov.xml

- name: Upload coverage to Codecov (non-PRs)
if: github.event_name != 'pull_request' # pushes, scheduled, etc.
- name: Upload coverage to Codecov (non PRs)
continue-on-error: true
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }} # required
flags: ${{ matrix.backend }}

# We need a separate step for PRs because PRs do not have access to
# secrets; hence, provide the token will give it an empty value,
# resulting in an authentication error.
- name: Upload coverage to Codecov (PRs)
if: github.event_name == 'pull_request' # PRs only
continue-on-error: true
uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
flags: ${{ matrix.backend }}
override_pr: ${{ github.event.pull_request.number }}

testing-guardian:
runs-on: ubuntu-latest
Expand Down
Loading