Commit 2187530
fix: diff to show the default rather than "unknown"
This (including the rest of the commit message) was AI-generated.
In `_compute_diff`, the expected support was derived via a raw dict lookup
on `expected_all` with "unknown" as the fallback. Features not explicitly
listed in the server profile (e.g. most features absent from the xandikos
compatibility hints) were therefore shown as expected="unknown" in the diff
output, instead of their actual default ("full" for standard server-features).
Fix by replacing the raw lookup with `self.expected_features.is_supported()`
which traverses the feature hierarchy and applies FeatureSet defaults.
prompt: why does `caldav-server-tester --name xnadikos --diff` report the expectations as "unknown" rather than default "full"? search.recurrences.expanded.exception is now reported to be supported by xandikos, while it's configured in ~/caldav/caldav/compatibility_hints.py to be unsupported. Please check if this is due to code changes on our side (either here or in the caldav library) or xandikos side. Also, why is this visible when doing `cd ~/caldav ; pytest -k 'xandikos and compat' --pdb`, but `pytest -k 'xandikos` passes without problems?
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 46f23f5 commit 2187530
2 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
9 | 14 | | |
10 | 15 | | |
11 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
175 | | - | |
| 175 | + | |
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| |||
0 commit comments