Expand search tests and remove fragile mocked tests

This commit enhances the CalDAV search functionality testing and improves
test maintainability:

## Search Test Improvements
- Add SearchMixIn class with search_find_set() helper method to reduce
  boilerplate in search feature testing
- Expand search feature coverage:
  - Text search (case-sensitive, case-insensitive, substring)
  - Property filter with CalDAVSearcher (is-not-defined operator)
  - Category search and substring matching
  - Combined search filters (logical AND behavior)
- Add post_filter=False to all server behavior tests to ensure we're
  testing actual server responses, not client-side filtering
- Improve comp-type-optional test with additional text search validation
- Add test event without summary property to validate optional fields

## Test Maintenance
- Remove test_ai_checks_with_mocks.py - these AI-generated mocked tests
  were fragile and difficult to maintain. The file itself documented
  that it should be deleted if it breaks. All meaningful test coverage
  is provided by the remaining unit tests.

## Bug Fixes
- Fix create-calendar feature detection to not mark mkcol method as
  standard calendar creation
- Capitalize event summary to match actual test data

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: tobixen

src/caldav_server_tester/checks.py

@@ -8,6 +8,7 @@
 from caldav.compatibility_hints import FeatureSet
 from caldav.lib.error import NotFoundError, AuthorizationError, ReportError, DAVError
 from caldav.calendarobjectresource import Event, Todo, Journal
+from caldav.search import CalDAVSearcher
 
 from .checks_base import Check
 
@@ -105,7 +106,10 @@ def _try_make_calendar(self, cal_id, **kwargs):
             ## calendar creation must have gone OK.
             calmade = True
             self.checker.principal.calendar(cal_id=cal_id).events()
-            self.set_feature("create-calendar")
+            ## the caller takes care of setting quirk flag if mkcol
+            ## (todo - does this make sense?  Actually the whole _try_make_calendar looks messy to me and should probably be refactored)
+            if kwargs.get('method', 'mkcalendar') != 'mkcol':
+                self.set_feature("create-calendar")
             if kwargs.get("name"):
                 try:
                     name = "A calendar with this name should not exist"
@@ -344,7 +348,7 @@ def add_if_not_existing(*largs, **kwargs):
 
         simple_event = add_if_not_existing(
             Event,
-            summary="simple event with a start time and an end time",
+            summary="Simple event with a start time and an end time",
             uid="csc_simple_event1",
             dtstart=datetime(2000, 1, 1, 12, 0, 0, tzinfo=utc),
             dtend=datetime(2000, 1, 1, 13, 0, 0, tzinfo=utc),
@@ -486,71 +490,129 @@ def add_if_not_existing(*largs, **kwargs):
 END:VCALENDAR""",
         )
 
+        simple_event = add_if_not_existing(
+            Event,
+            description="Simple event without a summary",
+            uid="csc_simple_event_no_summary",
+            dtstart=datetime(2000, 3, 1, 12, 0, 0, tzinfo=utc),
+            dtend=datetime(2000, 3, 1, 13, 0, 0, tzinfo=utc),
+        )
+
         ## No more existing IDs in the calendar from 2000 ... otherwise,
         ## more work is needed to ensure those won't pollute the tests nor be
         ## deleted by accident
         assert not object_by_uid
         assert self.checker.calendar.events()
         assert self.checker.tasklist.todos()
 
+class SearchMixIn:
+    ## Boilerplate
+    def search_find_set(self, cal_or_searcher, feature, num_expected=None, **search_args):
+        try:
+            results = cal_or_searcher.search(**search_args, post_filter=False)
+            cnt = len(results)
+            if num_expected is None:
+                is_good = cnt > 0
+            else:
+                is_good = cnt==num_expected
+            self.set_feature(feature, is_good)
+        except ReportError:
+            self.set_feature(feature, "ungraceful")
+    
 
-class CheckSearch(Check):
+class CheckSearch(Check, SearchMixIn):
     depends_on = {PrepareCalendar}
     features_to_be_checked = {
         "search.time-range.event",
-        "search.category",
-        "search.category.fullstring",
-        "search.category.fullstring.smart",
         "search.time-range.todo",
+        "search.text",
+        "search.text.case-sensitive",
+        "search.text.case-insensitive",
+        "search.text.substring",
+        "search.is-not-defined",
+        "search.text.category",
+        "search.text.category.substring",
         "search.comp-type-optional",
         "search.combined-is-logical-and",
     }  ## TODO: we can do so much better than this
 
     def _run_check(self):
         cal = self.checker.calendar
         tasklist = self.checker.tasklist
-        events = cal.search(
+        self.search_find_set(
+            cal, "search.time-range.event", 1, 
             start=datetime(2000, 1, 1, tzinfo=utc),
             end=datetime(2000, 1, 2, tzinfo=utc),
             event=True,
         )
-        self.set_feature("search.time-range.event", len(events) == 1)
-        tasks = tasklist.search(
+        self.search_find_set(
+            tasklist, "search.time-range.todo", 1,
             start=datetime(2000, 1, 9, tzinfo=utc),
             end=datetime(2000, 1, 10, tzinfo=utc),
             todo=True,
             include_completed=True,
         )
-        self.set_feature("search.time-range.todo", len(tasks) == 1)
 
-        ## search.category
-        try:
-            events = cal.search(category="hands", event=True)
-            self.set_feature("search.category", len(events) == 1)
-        except ReportError:
-            self.set_feature("search.category", "ungraceful")
-        if self.feature_checked("search.category", str) != 'ungraceful':
-            events = cal.search(category="hands,feet,head", event=True)
-            self.set_feature("search.category.fullstring", len(events) == 1)
-            if len(events) == 1:
-                events = cal.search(category="feet,head,hands", event=True)
-                self.set_feature("search.category.fullstring.smart", len(events) == 1)
+        ## summary search
+        self.search_find_set(
+            cal, "search.text", 1,
+            summary="Simple event with a start time and an end time",
+            event=True)
+
+        ## summary search is by default case sensitive
+        self.search_find_set(
+            cal, "search.text.case-sensitive", 0,
+            summary="simple event with a start time and an end time",
+            event=True)
+
+        ## summary search, case insensitive
+        searcher = CalDAVSearcher(event=True)
+        searcher.add_property_filter('summary', "simple event with a start time and an end time", case_sensitive=False)
+        self.search_find_set(
+            searcher, "search.text.case-insensitive", 1, calendar=cal)
+
+        ## is not defined search
+        searcher = CalDAVSearcher(event=True)
+        searcher.add_property_filter('summary', None, operator="undef")
+        self.search_find_set(
+            searcher, "search.is-not-defined", 1, calendar=cal)
+        
+        ## summary search, substring
+        ## The RFC says that TextMatch is a subetext search
+        self.search_find_set(
+            cal, "search.text.substring", 1,
+            summary="Simple event with a start time and",
+            event=True)
+
+        ## search.text.category
+        self.search_find_set(
+            cal, "search.text.category", 1,
+            category="hands", event=True)
 
         ## search.combined
-        if self.feature_checked("search.category"):
-            events1 = cal.search(category="hands", event=True, start=datetime(2000, 1, 1, 11, 0, 0), end=datetime(2000, 1, 13, 14, 0, 0))
-            events2 = cal.search(category="hands", event=True, start=datetime(2000, 1, 1, 9, 0, 0), end=datetime(2000, 1, 6, 14, 0, 0))
+        if self.feature_checked("search.text.category"):
+            events1 = cal.search(category="hands", event=True, start=datetime(2000, 1, 1, 11, 0, 0), end=datetime(2000, 1, 13, 14, 0, 0), post_filter=False)
+            events2 = cal.search(category="hands", event=True, start=datetime(2000, 1, 1, 9, 0, 0), end=datetime(2000, 1, 6, 14, 0, 0), post_filter=False)
             self.set_feature("search.combined-is-logical-and", len(events1) == 1 and len(events2) == 0)
-
+            self.search_find_set(
+                cal, "search.text.category.substring", 1,
+                category="eet",
+                event=True)
         try:
+            summary = "Simple event with a start time and"
+            ## Text search with and without comptype
+            tswc = cal.search(summary=summary, event=True, post_filter=False)
+            tswoc = cal.search(summary=summary, post_filter=False)
+            ## Testing if search without comp-type filter returns both events and tasks
             if self.feature_checked("search.time-range.todo"):
                 objects = cal.search(
                     start=datetime(2000, 1, 1, tzinfo=utc),
                     end=datetime(2001, 1, 1, tzinfo=utc),
+                    post_filter=False,
                 )
             else:
-                objects = _filter_2000(cal.search())
-            if len(objects) == 0:
+                objects = _filter_2000(cal.search(post_filter=False))
+            if len(objects) == 0 and not tswoc:
                 self.set_feature(
                     "search.comp-type-optional",
                     {
@@ -570,12 +632,15 @@ def _run_check(self):
                 cal != tasklist
                 and len(objects)
                 + len(
+                    ## Also search tasklist without comp-type to see if we get all objects
                     tasklist.search(
                         start=datetime(2000, 1, 1, tzinfo=utc),
                         end=datetime(2001, 1, 1, tzinfo=utc),
+                        post_filter=False,
                     )
                 )
-                == self.checker.cnt
+                == self.checker.cnt and
+                (tswoc or not tswc)
             ):
                 self.set_feature(
                     "search.comp-type-optional",
@@ -584,7 +649,7 @@ def _run_check(self):
                         "description": "comp-filter is redundant in search as a calendar can only hold one kind of components",
                     },
                 )
-            elif len(objects) == self.checker.cnt:
+            elif len(objects) == self.checker.cnt and (tswoc or not tswc):
                 self.set_feature("search.comp-type-optional")
             else:
                 ## TODO ... we need to do more testing on search to conclude certainly on this one.  But at least we get something out.
@@ -599,7 +664,7 @@ def _run_check(self):
             self.set_feature("search.comp-type-optional", {"support": "ungraceful"})
 
 
-class CheckRecurrenceSearch(Check):
+class CheckRecurrenceSearch(Check, SearchMixIn):
     depends_on = {CheckSearch}
     features_to_be_checked = {
         "search.recurrences.includes-implicit.todo",
@@ -661,6 +726,10 @@ def _run_check(self):
             event=True,
             post_filter=False,
         )
+        ## Xandikos version 0.2.12 breaks here for me.
+        ## It didn't break earlier.
+        ## Everything is exactly the same here.  Same data on the server, same query
+        ## There must be some local state in xandikos causing some bug to happen
         assert len(exception) == 1
         far_future_recurrence = cal.search(
             start=datetime(2045, 3, 12, tzinfo=utc),