Commit 002dac4
committed
fix: discover pre-running Docker servers even when docker-compose is unavailable
In CI (GitHub Actions ubuntu-latest / ubuntu-24.04), Baikal runs as a
service container that is already up before the tests start. The legacy
`docker-compose` standalone binary is not installed on these runners
(only the `docker compose` plugin is), so `verify_docker()` returned
False and `_discover_docker_servers()` bailed out without registering
Baikal. The async test job used `-k baikal` with no fallback, producing
exit-code 5 (no tests collected).
Two fixes:
* `verify_docker()` now accepts either `docker-compose --version` or
`docker compose version` (plugin form).
* `_discover_docker_servers()` no longer skips registration entirely when
Docker is not startable; it still registers servers that are already
accessible (e.g. a CI service container), letting `DockerTestServer.start()`
handle them with its existing "already running" detection.
prompt: have a look into this failure: gh run view 24923998455
AI Prompts:
claude-sonnet-4-6: have a look into this failure: `gh run view 24923998455`1 parent d26c9ba commit 002dac4
2 files changed
Lines changed: 17 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
308 | 308 | | |
309 | 309 | | |
310 | 310 | | |
311 | | - | |
| 311 | + | |
312 | 312 | | |
313 | 313 | | |
314 | 314 | | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | | - | |
329 | | - | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
334 | | - | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
335 | 325 | | |
336 | 326 | | |
337 | 327 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
301 | | - | |
| 300 | + | |
302 | 301 | | |
303 | 302 | | |
304 | 303 | | |
| |||
312 | 311 | | |
313 | 312 | | |
314 | 313 | | |
315 | | - | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
316 | 319 | | |
317 | 320 | | |
318 | 321 | | |
| |||
0 commit comments