hnng

Author: tobixen

CHANGELOG.md

@@ -14,10 +14,6 @@ This project should adhere to [Semantic Versioning](https://semver.org/spec/v2.0
 
 ## [Unreleased]
 
-### Breaking Changes
-
-* The icalendar dependency is updated from 6 to 7 - not because 3.0 depends on icalendar7, but because I'm planning to use icalendar7-features in some upcoming 3.x.  If this causes problems for you, just reach out and I will downgrade the dependency, release a new 3.0.1, and possibly procrastinate the icalendar7-stuff until 4.0.
-
 ### Added
 
 * **Stalwart CalDAV server** added to Docker test server framework.

pyproject.toml

@@ -56,7 +56,7 @@ dependencies = [
   "niquests",
   "recurring-ical-events>=2.0.0",
   "typing_extensions;python_version<'3.11'",
-  "icalendar>7.0.0",
+  "icalendar>6.0.0",
   "icalendar-searcher>=1.0.5,<2",
   "dnspython",
   "python-dateutil",

tests/test_async_davclient.py

@@ -821,6 +821,63 @@ def test_has_component_with_only_vcalendar(self) -> None:
         assert obj.has_component() is False
 
 
+class TestAsyncCalendarAddObject:
+    """Tests for Calendar.add_object/add_event/add_todo with async clients (issue #631)."""
+
+    SIMPLE_EVENT = """BEGIN:VCALENDAR
+VERSION:2.0
+PRODID:-//Test//Test//EN
+BEGIN:VEVENT
+UID:test-async-add-event@example.com
+DTSTART:20200101T100000Z
+DTEND:20200101T110000Z
+SUMMARY:Test Async Add Event
+END:VEVENT
+END:VCALENDAR"""
+
+    @pytest.mark.asyncio
+    async def test_add_event_returns_coroutine_with_async_client(self) -> None:
+        """Calendar.add_event() must be awaitable when using AsyncDAVClient.
+
+        Regression test for issue #631: o.save() returns a coroutine for async
+        clients, so add_object() must await it instead of doing o.url on the
+        coroutine object.
+        """
+        from caldav.aio import AsyncEvent
+        from caldav.collection import Calendar
+
+        client = AsyncDAVClient(url="https://caldav.example.com/dav/")
+        # Mock _async_create so no real HTTP happens
+        AsyncEvent._async_create = AsyncMock()
+
+        calendar = Calendar(client=client, url="https://caldav.example.com/dav/calendars/test/")
+
+        result = calendar.add_event(self.SIMPLE_EVENT)
+        # With an async client, add_event must return a coroutine
+        import inspect
+
+        assert inspect.isawaitable(result), (
+            "add_event() should return a coroutine when using AsyncDAVClient, "
+            "got %r instead" % result
+        )
+        event = await result
+        assert isinstance(event, AsyncEvent)
+
+    @pytest.mark.asyncio
+    async def test_add_event_result_has_url(self) -> None:
+        """Awaiting add_event() with async client returns an Event with a URL."""
+        from caldav.aio import AsyncEvent
+        from caldav.collection import Calendar
+
+        client = AsyncDAVClient(url="https://caldav.example.com/dav/")
+        AsyncEvent._async_create = AsyncMock()
+
+        calendar = Calendar(client=client, url="https://caldav.example.com/dav/calendars/test/")
+        event = await calendar.add_event(self.SIMPLE_EVENT)
+        # Should have a URL set (or None, but not crash)
+        _ = event.url  # must not raise AttributeError
+
+
 class TestAsyncRateLimiting:
     """
     Unit tests for 429/503 rate-limit handling in AsyncDAVClient.