a bit more work on this

Author: tobixen

tests/test_caldav.py

@@ -1709,7 +1709,7 @@ def testSearchSortTodo(self):
             dtstart=date(2022, 10, 11),
             uid="test1",
         )
-        assert(t1.is_pending())
+        assert t1.is_pending()
         t2 = c.save_todo(
             summary="2 task future",
             due=datetime.now() + timedelta(hours=15),
@@ -1732,7 +1732,7 @@ def testSearchSortTodo(self):
             status="COMPLETED",
             uid="test5",
         )
-        assert(not t5.is_pending())
+        assert not t5.is_pending()
         t6 = c.save_todo(
             summary="6 task has categories",
             categories="home,garden,sunshine",
@@ -1852,11 +1852,11 @@ def testSearchTodos(self):
             assert len(some_todos) - pre_cnt == 6
 
         ## completing events, and it should not show up anymore
-        assert(t3.is_pending())
+        assert t3.is_pending()
         t3.complete()
         t5.complete()
         t6.complete()
-        assert(not t3.is_pending())
+        assert not t3.is_pending()
 
         some_todos = c.search(todo=True)
         assert len(some_todos) == 3 + pre_cnt
@@ -1866,14 +1866,14 @@ def testSearchTodos(self):
         assert len(all_todos) == 6 + pre_cnt
 
         ## Just for increasing code coverage
-        t3.component.pop('COMPLETED')
-        assert(not t3.is_pending())
+        t3.component.pop("COMPLETED")
+        assert not t3.is_pending()
 
         ## Test that uncomplete works
         t5.uncomplete()
         some_todos = c.search(todo=True)
         assert len(some_todos) == 4 + pre_cnt
-        
+
     def testWrongPassword(self):
         if (
             not "password" in self.server_params
@@ -2002,16 +2002,24 @@ def testCreateChildParent(self):
         assert len(foo) == 0
         assert len(bar) == 0
 
-        another_parent.set_relation('ctuid4', reltype="CHILD")
+        another_parent.set_relation("ctuid4", reltype="CHILD")
         another_parent.load()
         another_child.load()
         assert another_child.check_reverse_relations() == []
         assert another_parent.check_reverse_relations() == []
         foo = another_parent.get_relatives(reltypes={"CHILD", "PARENT"})
         bar = another_child.get_relatives(reltypes={"CHILD", "PARENT"})
-        assert sum([len(x.get('CHILD', set())) + len(x.get('PARENT', set())) for x in [foo, bar]]) == 2
-        assert [str(obj.component['UID']) for obj in foo['CHILD']] == ['ctuid4']
-        assert [str(obj.component['UID']) for obj in bar['PARENT']] == ['ctuid5']
+        assert (
+            sum(
+                [
+                    len(x.get("CHILD", set())) + len(x.get("PARENT", set()))
+                    for x in [foo, bar]
+                ]
+            )
+            == 2
+        )
+        assert [str(obj.component["UID"]) for obj in foo["CHILD"]] == ["ctuid4"]
+        assert [str(obj.component["UID"]) for obj in bar["PARENT"]] == ["ctuid5"]
 
     def testSetDue(self):
         self.skip_on_compatibility_flag("read_only")
@@ -2102,6 +2110,17 @@ def testSetDue(self):
                 check_dependent=True,
             )
 
+        ## `todo.set_due` with `check_dependent='return'`
+        ## should return the parent
+        assert (
+            parent.component["uid"]
+            == some_todo.set_due(
+                datetime(2022, 12, 26, 21, 30, tzinfo=utc),
+                move_dtstart=True,
+                check_dependent="return",
+            ).component["uid"]
+        )
+
         child = c.save_todo(
             dtstart=datetime(2022, 12, 26, 19, 45),
             due=datetime(2022, 12, 26, 19, 55),