refactor: delete caldav/operations/ directory

As per docs/design/OPERATIONS_PROTOCOL_AUDIT.md: ~85% of the directory
was dead code. The 7 production-used functions have been moved to their
natural homes:

- _quote_uid → calendarobjectresource.py (inlined, removes import)
- _extract_calendars_from_propfind_results → collection.py
- _extract_calendar_home_set_from_results + _sanitize_calendar_home_set_url → collection.py
- _extract_calendar_id_from_url, _quote_url_path, _is_calendar_resource → collection.py
- _build_search_xml_query, _filter_search_results, _collation_to_caldav → search.py

davclient.py and async_davclient.py updated to import from collection.py.
CalendarInfo dataclass moved to collection.py.

All 6 test_operations_*.py files deleted (they only tested dead code;
behaviour is covered by integration tests against the classes).
8 operations/ source files deleted (2,205 lines removed).

prompt: Kill the operations directory ref the document

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

AI Prompts:
claude-sonnet-4-6: Kill the operations directory ref the document

Author: tobixen

caldav/async_davclient.py

@@ -968,12 +968,12 @@ async def get_calendars(self, principal: Optional["Principal"] = None) -> list["
                 print(f"Calendar: {cal.get_display_name()}")
         """
         from caldav.collection import Calendar
-        from caldav.operations.calendarset_ops import (
-            _extract_calendars_from_propfind_results as extract_calendars,
-        )
-        from caldav.operations.principal_ops import (
+        from caldav.collection import (
             _extract_calendar_home_set_from_results as extract_home_set,
         )
+        from caldav.collection import (
+            _extract_calendars_from_propfind_results as extract_calendars,
+        )
 
         if principal is None:
             principal = await self.get_principal()

caldav/calendarobjectresource.py

@@ -18,7 +18,7 @@
 from collections import defaultdict
 from datetime import datetime, timedelta, timezone
 from typing import TYPE_CHECKING, Any, ClassVar, Optional
-from urllib.parse import ParseResult, SplitResult
+from urllib.parse import ParseResult, SplitResult, quote
 
 import icalendar
 from dateutil.rrule import rrulestr
@@ -47,11 +47,19 @@
 from .lib.error import errmsg
 from .lib.python_utilities import to_normal_str, to_unicode, to_wire
 from .lib.url import URL
-from .operations.calendarobject_ops import _quote_uid
 
 log = logging.getLogger("caldav")
 
 
+def _quote_uid(uid: str) -> str:
+    """URL-quote a UID for use in a CalDAV object URL.
+
+    Slashes are double-quoted (replaced with %2F before percent-encoding)
+    per https://github.com/python-caldav/caldav/issues/143.
+    """
+    return quote(uid.replace("/", "%2F"))
+
+
 class CalendarObjectResource(DAVObject):
     """Ref RFC 4791, section 4.1, a "Calendar Object Resource" can be an
     event, a todo-item, a journal entry, or a free/busy entry

caldav/collection.py

@@ -13,11 +13,12 @@
 import logging
 import uuid
 import warnings
+from dataclasses import dataclass
 from datetime import date as _date
 from datetime import datetime, timezone
 from time import sleep
 from typing import TYPE_CHECKING, Any, Optional, TypeVar
-from urllib.parse import ParseResult, SplitResult, quote, unquote
+from urllib.parse import ParseResult, SplitResult, quote, unquote, urlparse, urlunparse
 
 import icalendar
 
@@ -48,17 +49,96 @@
 log = logging.getLogger("caldav")
 
 
+# ---------------------------------------------------------------------------
+# Helpers for extracting calendar / principal info from PROPFIND results.
+# These were previously in caldav/operations/calendarset_ops.py and
+# caldav/operations/principal_ops.py.
+# ---------------------------------------------------------------------------
+
+
+@dataclass
+class CalendarInfo:
+    """Data for a calendar extracted from a PROPFIND response."""
+
+    url: str
+    cal_id: str | None
+    name: str | None
+    resource_types: list[str]
+
+
+def _extract_calendar_id_from_url(url: str) -> str | None:
+    try:
+        parts = str(url).rstrip("/").split("/")
+        if parts:
+            cal_id = parts[-1]
+            if cal_id:
+                return cal_id
+    except Exception:
+        log.error(f"Calendar has unexpected url {url}")
+    return None
+
+
+def _quote_url_path(url: str) -> str:
+    """Quote the path component of a URL to handle unencoded spaces (e.g. Zimbra)."""
+    parsed = urlparse(url)
+    quoted_path = quote(unquote(parsed.path), safe="/@")
+    return urlunparse(parsed._replace(path=quoted_path))
+
+
+def _is_calendar_resource(properties: dict[str, Any]) -> bool:
+    rt = properties.get("{DAV:}resourcetype", [])
+    if not isinstance(rt, list):
+        rt = [rt] if rt else []
+    return "{urn:ietf:params:xml:ns:caldav}calendar" in rt
+
+
+def _extract_calendars_from_propfind_results(results: list[Any] | None) -> list[CalendarInfo]:
+    """Extract CalendarInfo objects from a list of PropfindResult objects."""
+    calendars = []
+    for result in results or []:
+        if not _is_calendar_resource(result.properties):
+            continue
+        url = _quote_url_path(result.href)
+        name = result.properties.get("{DAV:}displayname")
+        cal_id = _extract_calendar_id_from_url(url)
+        if not cal_id:
+            continue
+        calendars.append(
+            CalendarInfo(
+                url=url,
+                cal_id=cal_id,
+                name=name,
+                resource_types=result.properties.get("{DAV:}resourcetype", []),
+            )
+        )
+    return calendars
+
+
+def _sanitize_calendar_home_set_url(url: str | None) -> str | None:
+    """Quote @ in owncloud-style URLs that are not full URLs."""
+    if url is None:
+        return None
+    if "@" in url and "://" not in url and "%40" not in url:
+        return quote(url)
+    return url
+
+
+def _extract_calendar_home_set_from_results(results: list[Any] | None) -> str | None:
+    """Extract calendar-home-set URL from a list of PropfindResult objects."""
+    for result in results or []:
+        home_set = result.properties.get("{urn:ietf:params:xml:ns:caldav}calendar-home-set")
+        if home_set:
+            return _sanitize_calendar_home_set_url(home_set)
+    return None
+
+
 class CalendarSet(DAVObject):
     """
     A CalendarSet is a set of calendars.
     """
 
     def _calendars_from_results(self, results) -> list["Calendar"]:
         """Convert PropfindResult list into Calendar objects."""
-        from caldav.operations.calendarset_ops import (
-            _extract_calendars_from_propfind_results,
-        )
-
         calendar_infos = _extract_calendars_from_propfind_results(results)
         return [
             Calendar(client=self.client, url=info.url, name=info.name, id=info.cal_id, parent=self)

caldav/davclient.py

@@ -501,12 +501,12 @@ def get_calendars(self, principal: Principal | None = None) -> list[Calendar]:
             for cal in calendars:
                 print(f"Calendar: {cal.get_display_name()}")
         """
-        from caldav.operations.calendarset_ops import (
-            _extract_calendars_from_propfind_results as extract_calendars,
-        )
-        from caldav.operations.principal_ops import (
+        from caldav.collection import (
             _extract_calendar_home_set_from_results as extract_home_set,
         )
+        from caldav.collection import (
+            _extract_calendars_from_propfind_results as extract_calendars,
+        )
 
         if principal is None:
             principal = self.principal()