Reverting the niquests library - release version 1.5 should not introduce such dependency-changes

Author: tobixen

caldav/davclient.py

@@ -13,12 +13,12 @@
 from typing import Union
 from urllib.parse import unquote
 
-import niquests
+import requests
 from lxml import etree
 from lxml.etree import _Element
-from niquests.auth import AuthBase
-from niquests.models import Response
-from niquests.structures import CaseInsensitiveDict
+from requests.auth import AuthBase
+from requests.models import Response
+from requests.structures import CaseInsensitiveDict
 
 from .elements.base import BaseElement
 from caldav import __version__
@@ -402,7 +402,7 @@ def expand_simple_props(
 
 class DAVClient:
     """
-    Basic client for webdav, uses the niquests lib; gives access to
+    Basic client for webdav, uses the requests lib; gives access to
     low-level operations towards the caldav server.
 
     Unless you have special needs, you should probably care most about
@@ -432,26 +432,26 @@ def __init__(
          * url: A fully qualified url: `scheme://user:pass@hostname:port`
          * proxy: A string defining a proxy server: `hostname:port`
          * username and password should be passed as arguments or in the URL
-         * auth, timeout and ssl_verify_cert are passed to niquests.request.
+         * auth, timeout and ssl_verify_cert are passed to requests.request.
          * ssl_verify_cert can be the path of a CA-bundle or False.
          * huge_tree: boolean, enable XMLParser huge_tree to handle big events, beware
            of security issues, see : https://lxml.de/api/lxml.etree.XMLParser-class.html
 
-        The niquests library will honor a .netrc-file, if such a file exists
+        The requests library will honor a .netrc-file, if such a file exists
         username and password may be omitted.  Known bug: .netrc is honored
         even if a username/password is given, ref https://github.com/python-caldav/caldav/issues/206
         """
         headers = headers or {}
 
-        self.session = niquests.Session(multiplexed=True)
+        self.session = requests.Session()
 
         log.debug("url: " + str(url))
         self.url = URL.objectify(url)
         self.huge_tree = huge_tree
         # Prepare proxy info
         if proxy is not None:
             _proxy = proxy
-            # niquests library expects the proxy url to have a scheme
+            # requests library expects the proxy url to have a scheme
             if "://" not in proxy:
                 _proxy = self.url.scheme + "://" + proxy
 
@@ -747,11 +747,10 @@ def request(
             and self.username
         ):
             auth_types = self.extract_auth_types(r_headers["WWW-Authenticate"])
-
             if self.username and "digest" in auth_types:
-                self.auth = niquests.auth.HTTPDigestAuth(self.username, self.password)
+                self.auth = requests.auth.HTTPDigestAuth(self.username, self.password)
             elif self.username and "basic" in auth_types:
-                self.auth = niquests.auth.HTTPBasicAuth(self.username, self.password)
+                self.auth = requests.auth.HTTPBasicAuth(self.username, self.password)
             elif self.password and "bearer" in auth_types:
                 self.auth = HTTPBearerAuth(self.password)
             elif "bearer" in auth_types:
@@ -785,11 +784,11 @@ def request(
             auth_types = self.extract_auth_types(r_headers["WWW-Authenticate"])
 
             if self.password and self.username and "digest" in auth_types:
-                self.auth = niquests.auth.HTTPDigestAuth(
+                self.auth = requests.auth.HTTPDigestAuth(
                     self.username, self.password.decode()
                 )
             elif self.password and self.username and "basic" in auth_types:
-                self.auth = niquests.auth.HTTPBasicAuth(
+                self.auth = requests.auth.HTTPBasicAuth(
                     self.username, self.password.decode()
                 )
             elif self.password and "bearer" in auth_types:
@@ -801,8 +800,8 @@ def request(
 
         # this is an error condition that should be raised to the application
         if (
-            response.status == niquests.codes.forbidden
-            or response.status == niquests.codes.unauthorized
+            response.status == requests.codes.forbidden
+            or response.status == requests.codes.unauthorized
         ):
             try:
                 reason = response.reason

caldav/requests.py

@@ -1,4 +1,4 @@
-from niquests.auth import AuthBase
+from requests.auth import AuthBase
 
 
 class HTTPBearerAuth(AuthBase):

pyproject.toml

@@ -30,7 +30,7 @@ classifiers = [
 dependencies = [
   "vobject",
   "lxml",
-  "niquests",
+  "requests",
   "recurring-ical-events>=2.0.0",
   "typing_extensions;python_version<'3.11'",
   ## It's a mess - newer versions of xandikos, used for testing, does not support python 3.8 anymore.  icalendar 6.0.0 is not compatible with elder versions of xandikos.  It's no problem with python 3.7, as icalender 6.0.0 does not support python 3.7.

tests/conf.py

@@ -8,7 +8,7 @@
 import threading
 import time
 
-import niquests
+import requests
 
 from caldav import compatibility_hints
 from caldav.davclient import CONNKEYS
@@ -127,7 +127,7 @@ def setup_radicale(self):
         i = 0
         while True:
             try:
-                niquests.get(str(self.url))
+                requests.get(str(self.url))
                 break
             except:
                 time.sleep(0.05)
@@ -207,7 +207,7 @@ def teardown_xandikos(self):
         ## ... but the thread may be stuck waiting for a request ...
         def silly_request():
             try:
-                niquests.get(str(self.url))
+                requests.get(str(self.url))
             except:
                 pass
 

tests/test_caldav.py

@@ -24,6 +24,7 @@
 import icalendar
 import pytest
 import vobject
+from requests.packages import urllib3
 
 from .conf import caldav_servers
 from .conf import client
@@ -59,6 +60,7 @@
 
 log = logging.getLogger("caldav")
 
+urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
 
 ev1 = """BEGIN:VCALENDAR
 VERSION:2.0

tests/test_caldav_unit.py

@@ -366,7 +366,7 @@ class TestCalDAV:
     dependencies, without accessing any caldav server)
     """
 
-    @mock.patch("caldav.davclient.niquests.Session.request")
+    @mock.patch("caldav.davclient.requests.Session.request")
     def testRequestNonAscii(self, mocked):
         """
         ref https://github.com/python-caldav/caldav/issues/83
@@ -423,7 +423,7 @@ def testLoadByMultiGet404(self):
         with pytest.raises(error.NotFoundError):
             object.load_by_multiget()
 
-    @mock.patch("caldav.davclient.niquests.Session.request")
+    @mock.patch("caldav.davclient.requests.Session.request")
     def testRequestCustomHeaders(self, mocked):
         """
         ref https://github.com/python-caldav/caldav/issues/285
@@ -441,7 +441,7 @@ def testRequestCustomHeaders(self, mocked):
         ## User-Agent would be overwritten by some boring default in earlier versions
         assert client.headers["User-Agent"] == "MyCaldavApp"
 
-    @mock.patch("caldav.davclient.niquests.Session.request")
+    @mock.patch("caldav.davclient.requests.Session.request")
     def testRequestUserAgent(self, mocked):
         """
         ref https://github.com/python-caldav/caldav/issues/391
@@ -455,7 +455,7 @@ def testRequestUserAgent(self, mocked):
         assert client.headers["Content-Type"] == "text/xml"
         assert client.headers["User-Agent"].startswith("python-caldav/")
 
-    @mock.patch("caldav.davclient.niquests.Session.request")
+    @mock.patch("caldav.davclient.requests.Session.request")
     def testEmptyXMLNoContentLength(self, mocked):
         """
         ref https://github.com/python-caldav/caldav/issues/213
@@ -465,7 +465,7 @@ def testEmptyXMLNoContentLength(self, mocked):
         mocked().content = ""
         client = DAVClient(url="AsdfasDF").request("/")
 
-    @mock.patch("caldav.davclient.niquests.Session.request")
+    @mock.patch("caldav.davclient.requests.Session.request")
     def testNonValidXMLNoContentLength(self, mocked):
         """
         If XML is expected but nonvalid XML is given, an error should be raised